avniproject / avni-client

Android app for the fieldworkers.
https://avniproject.org
GNU Affero General Public License v3.0
7 stars 20 forks source link

[Documentation] Translation for keys with dynamic values #1444

Open Dinesh2019 opened 4 months ago

Dinesh2019 commented 4 months ago

We have uploaded the translation in the lokalise for some sentence we have translation but not displayed in the cilent app.

Env : prod org : apfodisha user : dinesh@apfodisha

Steps to reproduce :

1.Upload the bundle in the lokalise 2.Login to the cilent app 3.Change the language to odisa 4.enroll the pregancy program 5.Under the weight give the value as 100

Expected : error should be displayed in the odisha language Actual : still displays in english

Refer screenshot :

Screenshot 2024-06-28 at 12 12 49 PM

file uploaded in lokalise :

no_filename.json

form details : Pending for translation.xlsx

Root cause:

Its because the above kind of messages which can have dynamic values, doesn't need translation for each msg. Instead the generic keys needs translations: numberAboveHiAbsolute and numberBelowLowAbsolute

AC:

Analysis note:

I understand the difficulty of moving documentation from docs to readme. It was so because of a different process agreed with other teams. Going forward we can update directly in readme.

mahalakshme commented 4 months ago

@Dinesh2019 also mention the form name, steps to reproduce the issue.

I dont see trnaslation for 'should be 90, or less than 90' in the json file. Is the error message dynamically generated? from some rule?

AnjaliBhagabati commented 2 months ago

@mahalakshme this issue is happening will all the translations mentioned as not yet in this sheet in column " [Uploading Pending for translation.xlsx…]() F"

AnjaliBhagabati commented 2 months ago

@mahalakshme here is the json file [Uploading or1.json…]()

mahalakshme commented 2 months ago

It will work when translations added for keys: numberBelowLowAbsolute and numberAboveHiAbsolute

himeshr commented 2 months ago