avniproject / avni-client

Android app for the fieldworkers.
https://avniproject.org
GNU Affero General Public License v3.0
7 stars 21 forks source link

Improve performance of RadioButton and Checkbox #855

Closed vinayvenu closed 1 year ago

vinayvenu commented 1 year ago

This should improve performance of the app throughout the app.

(Expected to go in a patch release)

What has been been changed

What has been not been changed

Testing

Edit of enrolment, encounter and registration details raised as part of #854 need to be tested here

vinayvenu commented 1 year ago

To remember - usage of setState on RadioGroup has no purpose, and can be removed

petmongrels commented 1 year ago
mahalakshme commented 1 year ago

Edit of enrolment, encounter and registration details raised as part of #854 need to be tested here

mahalakshme commented 1 year ago

Testing: in JSCS: - viveks@jscs - Anuppur catchment Old:

New:

in Ashwini: - sachink@ashwini, Gudulur catchment Old: Edit of previous completed visit(the first page has checkboxes and radio buttons): 3s Edit of program enrolment(the first page has checkboxes and radio buttons): 3s

New: Edit of previous completed visit: 1.5s - 50% faster Edit of program enrolment: 1.5s - 50% faster

himeshr commented 1 year ago

Additional Testing info for JSCS: - viveks@jscs

While editing Subject registration details, in AddressLevel Block section, switching from "Pushparajgarh" from "Anuppur" took 39 seconds with RadioGroup(Old), but took only 13 seconds with SelectableItemGroup(New).