avniproject / avni-product

https://avniproject.org/
7 stars 10 forks source link

Voided data which is coming as false in gdgs 2023 data for atecf #1584

Closed siddhant3030 closed 2 months ago

siddhant3030 commented 2 months ago

hey,

So from the gdgs 2023 dataset I found out that few data is a test data and in the Voided column its mentioned False. Which is what I'm using to filter to remove the deleted data so why upon deleting Voided column status is not changing? is suppose to change it to TRUE right?

I have use this query which gives this result

select "ID", "Voided" from gdgsgom_2023.subjects where "ID" = '52aa386a-fd74-49ce-bb5c-34b4589c1657'

52aa386a-fd74-49ce-bb5c-34b4589c1657    false

and data looks like this

52aa386a-fd74-49ce-bb5c-34b4589c1657 Aagaskhind Pt. (Voided~375621)

mahalakshme commented 2 months ago

@arjunk kindly provide the needful info for siddhant to be able to create support tickets

arjunk commented 2 months ago

I have created a ticket for now https://avni.freshdesk.com/a/tickets/3901 to understand the context and confirm if this is a product issue

arjunk commented 2 months ago

Just on further probing, we understood this from the database Waterbody (Address Level in Avni id 375621 ) is voided. Workorder is not voided. The ID and voided status in your query that you are showing are related to workorder. But the name you are displaying in the subsequent result is of Waterbody. I think the system right now allows the addresslevel/location/waterbody to be marked as voided even though there are subjects/workorder against them.

You would need to check voided on both Waterbody and Workorder to filter the unnecessary data. I am marking this as closed here. In case further clarification is required on this you can reply on the ticket.

siddhant3030 commented 2 months ago

Yes, I've understood this by looking at the api's later. But this is very hard to find in a lot of data and I could've easily missed this if I was not checking the data manually. I was expecting if I've have removed the data where Voided is TRUE then I've removed the unnecessary data

Siddhant Singh Product Engineer

On Mon, Apr 29, 2024 at 2:52 PM Arjun Khandelwal @.***> wrote:

Just on further probing, we understood this from the database Waterbody (Address Level in Avni id 375621 ) is voided. Workorder is not voided. The ID and voided status in your query that you are showing are related to workorder. But the name you are displaying in the subsequent result is of Waterbody. I think the system right now allows the addresslevel/location/waterbody to be marked as voided even though there are subjects/workorder against them.

You would need to check voided on both Waterbody and Workorder to filter the unnecessary data. I am marking this as closed here. In case further clarification is required on this you can reply on the ticket.

— Reply to this email directly, view it on GitHub https://github.com/avniproject/avni-product/issues/1584#issuecomment-2082246197, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACE2ENRLEGCZ4CA53IIDKB3Y7YGL7AVCNFSM6AAAAABG5YJ4M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBSGI2DMMJZG4 . You are receiving this because you authored the thread.Message ID: @.***>