Case insensitive location matching

[mahalakshme]

https://avni.freshdesk.com/a/tickets/3751 https://avni.freshdesk.com/a/tickets/3897

Issue:

Frequently same location with different cases are uploaded leading to duplicate locations and corrupted data(individuals registered in both locations). This in turn causes issues when updating locations, say when trying to update location properties via CSV since multiple locations with same parent would exist.

AC:

• In the webapp Admin tab, when creating a location, when a same location exist with different case and in the same location hierarchy, show error in the field as 'This location already created as part of the mentioned larger location' in red color in place of 'This field is required' in the below screenshot. The typed location name need to be retained when showing the error. The snackbar message at the bottom need not be shown.

• But if the same existing location name created as part of different location hierarchy it should be allowed.
• Via CSV upload as well, the above needs to work by showing the error for the corresponding location in the 'error' column in the error file that will get downloaded.

[1t5j0y]

• Fixed for create/update via webapp.
• Leveraging existing server side error display mechanism (via toast message) and not changing it for this card.
• Location create via CSV upload already looks for existing address level titles ignoring case and treats it as an update of the existing record scenario if a match is found i.e. does not create a new location entry and does not throw an error.

[mahalakshme]

@1t5j0y can you share some screenshot of the error message. Mentioned the AC for error message so, since it was also the way how it was handled currently in certain cases. You mean we will be showing the toast in the screenshot along with the error message in the field? If so, that is fine. If not kindly share screenshot.

[1t5j0y]

@mahalakshme here you go

[mahalakshme]

@1t5j0y found the below issue:

• What I meant by this But if the same existing location name created as part of different location hierarchy it should be allowed. is that there are valid cases where two villages of same name can exist - when it is part of different taluka/block/state. Hence for such cases we should not show error. That is why mentioned this as error message "This location already created as part of the mentioned larger location".
• Since toast disappears within sometime, I preferred mentioning error messages close to fields since we have done so in some cases. But if it is more work, then the current behavior of showing error messages is fine.

[mahalakshme]

Joy mentioned the above is handled

[AchalaBelokar]

• [x] Uttar Pradesh as state present in rwbmh on satging I entered a Uttar pradesh it doesn’t allow me, uttar pradesh it doesn’t allow me uttarpradesh it allow me
• [x] created one location AchalaB@rwbniti via csv upload Maharashtra,Kolhapur,Kagal,Balikre,Percolation Tank Balikre,"Water Conservation Department, Kolhapur",Balikre,74.319336,16.346952,1260
• [x] and then I uploaded location maharshtra it uploaded successfully not showing any error it should show me error msg in the csv.but location is not created
• [x] I uploaded csv with maharshtr location is created.
• [x] Also uploaded diff level of location with lowercase I uploaded successfully not showing any message through csv.

[himeshr]

@AchalaBelokar and @mahalakshme As per our discussion, we do not have to mark the csv upload entry as error, when the case is not same as previous value for the same addressLevel, as it helps avoid User reuploads with minor case corrections. So moving it back to QA Ready, for further validation if needed.

[AchalaBelokar]

• [ ] Edit location is case sensitive it don’t allow if any thing which is case is upper

edit location.csv

errors-edit location (1).csv

[mahalakshme]

@AchalaBelokar found it is working fine, in rwb staging. tested with below 2. only issue is that for Edit+create it expects parent locations to be of same case - which can be fixed later(as part of this card - need not be blocker for release), since it will not lead to corrupted data

edit_location_edit_rwb_2 copy.csv edit_location_edit_rwb_2.csv