avniproject / avni-server

Backend APIs for Avni
https://avniproject.org
GNU Affero General Public License v3.0
5 stars 25 forks source link

Residual program exit observations left in db #736

Open mahalakshme opened 1 month ago

mahalakshme commented 1 month ago

In order to prevent loss of data we prevented clean swipe of observations logging this message 'ProgramEnrolment Exit Observations not all allowed to be made empty. User: swagh22@ihmp, UUID: 3adf4b3a-25a0-467b-abb5-c2f42be8b3cd'. But when a user undos program exit, we are intentionally clearing the exit observations. Now clearing this as well is blocked. But since UI rendering is decided by program_exit_date_time presence we see as expected. Also again when we do program exit, we dont do union with the existing observations, we instead do fresh insert. So so far, there is no impact to the user. But this is good to fix so that we have the code doing what is expected.

shraddha761 commented 1 month ago

@mahalakshme will you please provide some more details on this.

mahalakshme commented 4 weeks ago

@shraddha761 I suggest you to pick up a different card, since this needs some background context of what happened. Let me know if you are facing any difficulties to find issues that you would like to work on.

shraddha761 commented 4 weeks ago

@mahalakshme Yah please it would be great.