avniproject / avni-server

Backend APIs for Avni
https://avniproject.org
GNU Affero General Public License v3.0
7 stars 25 forks source link

Default filters not to break in older version of client #782

Closed mahalakshme closed 1 month ago

mahalakshme commented 2 months ago

Issue:

Currently when we make the custom default dashboard as the primary dashboard it will not work in older versions of mobile app since 'subject type' filter and 'as on date' filter were not supported before and the app is seen to crash like below:

Image

AC:

petmongrels commented 1 month ago

code review

himeshr commented 1 month ago

Code review comments, 2 things pending:

Additionally, a small Support write-up on handling update of lastModifiedDateTime, to sync Dashboard related entities to old clients, for orgs with change only in old config

himeshr commented 1 month ago

@petmongrels, Found 1 issue as of now during QA:

Inspite of this, on first time sync of AchalaB@shelteruat user, i still received Custom Dashboards with names "Default Dashboard", 'htestdash' and 'htestdash2' which were created /updated on 09-sep-2024, which shouldn't be the case.

Screenshot 2024-09-11 at 6 41 12 PM

Screenshot 2024-09-11 at 6 41 27 PM

Screenshot 2024-09-11 at 6 42 31 PM
himeshr commented 1 month ago

Its now Working as designed.. Pending tasks before deployment:

mahalakshme commented 1 month ago

Add documentation for workaround for backward compatibility issue(new report cards not working with old client) explaining the usecase in readme - under Implementors guide - somewhere linking this guide - needed to communicate further with implementation team

petmongrels commented 1 month ago

appendix section - https://github.com/avniproject/avni-product/releases