Voided answer concepts showing up in App designer

mahalakshme commented 8 months ago

Describe the bug

Currently coded answer concepts which have been removed from the coded concept still show up in App Designer.

To Reproduce

Steps to reproduce the behaviour:

Create a coded concept with A, B, C and D as answers to coded concept
Now, remove A as the answer to the coded concept
But when we search for concept A on App designer, It will still show as answer to the coded concept

Refer this video to understand the issue:

Expected behavior

The removed concept A should not show up as part/answer to the coded concept

ombhardwajj commented 5 months ago

@mahalakshme , @vinayvenu I have fixed this issue and submitted a PR. Please have a look!

petmongrels commented 2 months ago

@ombhardwajj

Some background.

This is the domain model of Concept answers.

Concept entity has one to many ConceptAnswer entity
ConceptAnswer entity has one to one to with child Concept entity

What should happen in remove answer

ConceptAnswer should be voided
nothing should be done to child Concept (as it may be used elsewhere)

Implementing this when the new Concept Answer has not been saved even once

To identify this you will see that id/uuid will be empty/null
Just remove it from the Concept Answer array

Implementing this when the new Concept Answer has not been saved and being removed

When it is removed void it in web app. Server call is not required yet.
When save is pressed, web app should send the array consisting of voided ConceptAnswer also. The server should persist voided ConceptAnswers also by setting the field.

mahalakshme commented 1 month ago

@ombhardwajj are the above code review comments resolved?

ombhardwajj commented 1 month ago

@mahalakshme No they have not been resolved , I am currently working on metabase issue and will only be able to work on this once that issue is complete!

avniproject / avni-webapp