App designer should not break on invalid glific configuration

mahalakshme commented 6 months ago

Issue raised by several tickets and people in implementation team.

when the /messageTemplates call fails, do the below on different scenarios,

In the Show mode, when the /messageTemplates call fails, and when there are no message rules, it should not fail, and the subject type need to show
In the Edit mode, when the /messageTemplates call fails, and when there are no message rules, show the error message as below along with other usual subject type information on click of 'Add new message rule'
In the Show mode, when there are message rules, show the other subject type info, along with the error message as above.
In the Edit mode, when there are message rules, show the other subject type info, alone with the error message as above. When user tries to add more message rules by clicking on 'Add new message rule', again show the above error message. It is okay if the error message displays multiple times on the page
The above needs to work across entity types (program, subject type, encounter type)
Similar above behaviour for User Messaging Config of App designer as well.

The above was decided to be done, instead of handling it when toggling on Enable Messaging in Organisation Details because of the below reasons:

The credentials might become invalid at a later point of time, after enabling messaging.
The implementation engineer might enable it from db

mahalakshme commented 1 month ago

username: maha@lahi env: prerelease encounter type: LAHI INTERN ATTENDANCE

fails because of incorrect configuration - ve already added the above case in AC above

Also 2nd AC looks like is not implemented - These things will again come via self-service or some other route that it is not evident.

petmongrels commented 1 month ago

@mahalakshme was master server deployed on prerelease to test this?

mahalakshme commented 1 month ago

@petmongrels no previously this was part of 10.0. The above is released. I changed it to 10.1, since found the above issues.

If you have done the above, intentionally for some reason, you can let me know.

dinesh2096 commented 2 days ago

[ ] When try to save without mandatory fields we are not displayed with any errors
[ ] And also we are not getting any error while configurating the message rule

Reference video :

himeshr commented 15 hours ago

Additional fixes done

Fixed broken "On save" click operation User-experience during create / edit of following entityTypes:

We have not introduced UI validation for MessageRules form-section, as its a bigger changes and not part of scope for this card
MessageRule."Name" not empty validation is not strictly adhered to in DB in some scenarios