Upload User and Catchment data

mahalakshme commented 2 months ago

Currently we are not doing validations on data/presence of data. This leads to issues like below:

Failing of sending Glific messages since username not present (When configured in User Messaging Config) - https://avni.freshdesk.com/a/tickets/3682

We expect country code to be mentioned for phone numbers and we dont give user friendly message when it is missing. And neither it is expected when user creates users via webapp. And we have hardcoded to support only Indian mobile numbers.

Sometimes error messages are not understandable for the users eventhough we provide readable error messages.
https://avni.freshdesk.com/a/tickets/3493
Validation on headers not done: https://avni.freshdesk.com/a/tickets/3568
When a user belongs to multiple user groups, they need to be separated by |. But everywhere else generally the separator is , https://avni.freshdesk.com/a/tickets/3902
Other tickets related to error messages and location hierarchy spelling mistakes https://avni.freshdesk.com/a/tickets/2496 https://avni.freshdesk.com/a/tickets/2863, https://avni.freshdesk.com/a/tickets/2494

Currently we have this regex validation for mobile number "^\\+91[0-9]{10}". Remove it and handle it when receiving the response for AdminCreateUserRequest by catching the exception InvalidParameterException and checking for 'Invalid phone number format' error message. In this case, the error column in CSV need to display as 'Country code not present or incorrect'. This is because validity of mobile numbers are not checked on AWS side.

Dont make it mandatory to enter + for phone number. If it is not entered, add + before sending the request to AWS cognito and inserting into db. If it is entered as well fine. This is because entering + on excel for a mobile number converts it into exponential format.
When the mobile numbers are prefixed with 91 or +91 make sure the number of digits that follows are ten in number.
When values for mandatory fields not present in the uploaded data then display the error in the error column of CSV as Value for 'Mobile number' column is missing in the respective row.

CSV upload to work with comma separator for user groups as well instead of bar symbol.
When location in the column 'Location with full hierarchy' is not present in Avni, then error message is 'Provided Location does not exist. Please check for spelling mistakes '%s''. Instead make the message to 'Provided Location does not exist in Avni. Please add it or check for spelling mistakes '%s''' . Reason: When we say doesn't exist, users dont realise we mean in Avni context.
Even if descriptor row present/not present as part of uploaded data, upload of data should work fine.
In the location with full hierarchy, the upload should have the same behaviour, independent of the case of the location. Say Kerala->Kasaragod is the location hierarchy, it should work even if the upload file contains, kerala->kasaragod

vinayvenu commented 1 month ago

Need QA scenarios for the phone number changes in behaviour

petmongrels commented 1 month ago

https://avni.readme.io/docs/phone-number-formats
error message for phone numbers will be based on the library error messages
+91 1111 1111 is invalid phone number, but the error will come only when saving as the front end validator seems to allow it.

avniproject / avni-webapp