[Dashboard] Misc pending tasks

avniproject / avni-webapp

Web application for management and data entry

https://avniproject.org

GNU Affero General Public License v3.0

12 stars 42 forks source link

[Dashboard] Misc pending tasks #1279

Closed mahalakshme closed 1 month ago

mahalakshme commented 3 months ago

AC:

When standard report cards of types related to Approval, Comments, Tasks and Checklist, is added with filter other than Address filter, display error stating 'Standard report cards of types related to Approval, Comments, Tasks and Checklist currently doesn't support any filter other than Address. ' like we display for other pages(screenshot below) and disallow saving.
- Should work when such card added when filter other than Address filter present
- Should work when such filter added when cards of such types already present
- Should work when both added together

shivansh84ya commented 3 months ago

could you please assign this issue to me

mahalakshme commented 3 months ago

@shivansh84ya this card is not yet Ready to be picked up. It is still in Analysis stage.

petmongrels commented 2 months ago

Functional changes

error displayed like other error message on create/edit dashboard

AC Not implemented

Primary dashboard should not display under More -> Dashboards Reason: If a user is part of multiple groups and is more than one group has primary/secondary dashboard set, then our logic of not showing primary dashboard can work differently when showing primary dashboard and when removing the primary dashboard from list of dashboards. Currently we are just picking one dashboard randomly among many which may be set as primary=true

himeshr commented 1 month ago

@Dinesh2019 i was unable to reproduce the error and exploring potential NPE using the stacktrace also failed. I deployed latest master code on staging env. I also verified that the functionality works as per AC specified above. Please take it up for QA again.

himeshr commented 1 month ago

@Dinesh2019

Updated the error message content to be more descriptive.
Adding standard and non standard cards in the same section doesn't change the filter-card constraint which is at the Dashboard Level (Higher than Section level).