Avni Web App - Code base Improvement Ideas

[arjunk]

DEA

• Small components, right now component size is huge because of this there's lot of duplication.
• Reuse and removing the duplication (e.g. EncounterTypeCreate/Edit)
• Consistency, state should be used everywhere to store and pass the data. (Check the Relationship component it uses local storage to store and retrieve the data). (e.g. EncounterTypeCreate/Edit)
• Pushing/reusing a lot of logic from avni-models.
• Separating out action logic to the independent files (Example check subjectRegisterSaga, it holds logic for registration and enrolment)
• State naming conventions (all the component state is named by appending reducer, creates confusion).
• Discussion on how Sagas are helping

Admin and App Designer

• Lot of code duplication between Edit and Create components (dealing with view, data loading and state management). In many cases two components are not required and one component will do the job. (e.g. EncounterTypeCreate/Edit)
• reducer and/or hooks (we can discuss pros and cons) (e.g. EncounterTypeCreate/Edit)
• use service or put logic in reducer. where to make server calls from
• use of constants instead of strings
• reusable components
• functions outside render (e.g. EncounterTypeCreate/Edit)

Given that avni models is a separate module, it poses resistance to developers to add business logic there - because it involves tiresome workflows and hence one wouldn't want to do this repeatedly. We will have to think about how to make this easy. Mono-repo and doing some work with package dependencies is one idea to solve it. There could be others.

• web app deals with a few more fields in model and may need to have methods specific to itself, not relevant to mobile app

Developer in group code walkthrough of the problem is solved for each of above. I feel a mob pairing session for each type will be great after that.

Refactored code which we can look at:

• ProgramService, ProgramCreate/ProgramEdit, ApplicationMenuEdit (should be renamed to AMCE)

[petmongrels]

Building blocks

UI (components, views) - models Actions/Reducers (management of state) - models Service (interaction with the server) - models Models (avni models)

Where does saga fit in this?

Learn about map state to props. useSelector, saga