search

avniproject / integration-service

Service for integration Avni with other systems
GNU Affero General Public License v3.0
0 stars 2 forks source link

Only process those Glific FlowResults which has "registration_flow_complete" set to "Yes" #102

Closed himeshr closed 9 months ago

himeshr commented 10 months ago

In Glific, Flow_results with same ID are saved multiple times to BigQuery Flow_results table. This results in partially completed flows also to be returned in the BigQuery SQL Query response. Only process those Glific FlowResults which has "registration_flow_complete" set to "Yes", which is an indicator that Contact has completed the entire flow.

Sample flow_results results column excerpts

{...
      "registration_flow_complete": {
        "category": "",
        "input": "Yes",
        "inserted_at": "2023-10-27T10: 36: 01.788664Z",
        "value": "Yes"
      }
}
himeshr commented 10 months ago

Code Review comments:

*) Set to simpledate using DateTimeUtil.registrationDate() in

Date registrationDate = DateTimeUtil.toDate(lahiStudent.getDateOfRegistration(), DateTimeUtil.DATE_TIME);

*) Look into this test "NoSuchElementExceptionWhenIteratingThroughAFullClass"

vinayvenu commented 10 months ago

Item 1 fixed Item 2 should not be a problem. The method has been replaced

AchalaBelokar commented 10 months ago

https://docs.google.com/spreadsheets/d/191uuBE2R9Q8U0WKfBDsfECX0OiI0zXHpjkBxiZPeK58/edit#gid=346525539

himeshr commented 9 months ago

Need more info on the following issue reported: When we are clicking on subject type it is showing opps there was a problem when loading this page.

himeshr commented 9 months ago

https://docs.google.com/spreadsheets/d/191uuBE2R9Q8U0WKfBDsfECX0OiI0zXHpjkBxiZPeK58/edit#gid=346525539

Fixed the reproducible issues reported in the Error sheet.