avniproject / integration-service

Service for integration Avni with other systems
GNU Affero General Public License v3.0
0 stars 2 forks source link

Improve monitoring capability of Integration service #47

Closed himeshr closed 1 year ago

himeshr commented 1 year ago

To improve monitoring capability of Integration service:

petmongrels commented 1 year ago

@himeshr @vinayvenu I think we have mis implemented the error handling in Goonj. We have blanket catch exception which will also catch any code issues. This means that the integration will complete even if there is a coding issue, network issue. For these errors we have to stop and not process further as their is not point in processing records if the systems are unavailable or code has a bug. ErrorRecords are useful only if there are known application scenarios.

This way we will create too many errors and use the error log as Bugsnag. Lets discuss on Monday.

himeshr commented 1 year ago

Current status of tasks in-progress:

  1. Code changes are in draft for error-msg storing in error_record_log table (Unable to upload patch here, ping me if needed)
  2. Draft Query created in Metabase, check https://reporting.avniproject.org/collection/449-avni-integration
himeshr commented 1 year ago

Code changes have been deployed to staging and prod integration servers.