Confirmation message before save

avo-hq / avo

Build Ruby on Rails apps 10x faster

https://avohq.io

Other

1.44k stars 228 forks source link

Confirmation message before save #2843

Open filipegiusti opened 1 month ago

filipegiusti commented 1 month ago

Feature

When opening the edit page or when saving a resource, users should see a confirmation modal.

Current workarounds

I guess it could be achieve by manually replicating the default actions list and overriding the save button.

Screenshots or screen recordings

N/A.

Additional context

We would like the ability to ask for confirmation on saves depending on resource state because some of our resources have states that are low stakes (unpublished) and ones that are high stakes (published) and we would like to avoid human error on high stakes states.

Initially discussed this discord thread.

G-Simpson commented 1 week ago

@filipegiusti Could you please post the context from the discord thread? I don't have access. Thanks

adrianthedev commented 1 week ago

Hey @G-Simpson. In case you want to join, use this link https://avo.cool/chat

adrianthedev commented 1 week ago

This would be a cool feature to have!

Approach

add the confirm_before_create|update|save option to BaseResource
create a Stimulus controller which gets attached in case the option is on
the stimulus controller will first show a modal
let's re-use the custom-confirm.js behavior to trigger the same modal. Some work will be required here to extract that functionality
the modal should trigger a proper submit on the form

BTW, you can check out that thread here on the public chat archives.

G-Simpson commented 1 week ago

I'm happy to have a look at this