Assignment 3 - Twitter

[avo1]

Hi /cc @coderschoolreview, here's my submission.

[coderschoolreview]

:checkered_flag: It's a pleasure to grade your work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API.

Grading Summary

Functionality: Good Code Style: Excellent Visual Design: Good Usability: Good Overall: Good

Great things:

• Good work with clean auto layout constraints. Nice (and pretty) handling of "username retweeted" label at the top of a tweet cell.
• Cell estimated row height has a good value.
• On Tweet Compose view, great job with a) using UITextView to support text input over multiple lines b) disabling the Tweet button for invalid character count and c) use UIAlertController for the Cancel (X) button.
• Great job using the naming convention for text constant, e.g. "consistentNamingIsGreat"

Some suggestions/ideas for improvement:

• Logout bar button on the navbar isn't visible. You may have removed the text by mistake.
• After I favorite a tweet from the detail view, I go back to the table and see that the tweet is not favorited. Use viewWillAppear to reload tableview. It looks like if I favorite or retweet from the timeline then go to the tweet, it's not updated either.
• Show images for tweets with images on the timeline screen.
• Good to see up to 20 latest tweets on the home timeline as requested. Consider adding infinite loading for scrolling further.
• Good to see that you tend to use self. only when necessary, but there are still some places where you don't need. One code convention is to avoid it if not necessary for conciseness: https://github.com/raywenderlich/swift-style-guide#use-of-self
• Add constraint between username and timeago to prevent overlapping:
• On iphone 5s simulator, tableview doesnt load properly at first. Pull to refresh fixes it though.

As you already know by now, we encourage spending a lot of time of the homework to learn much more and to have a better portfolio of your own work. Thank you for your dedication to spending time, learning and helping friends in class.

[avo1]

Thanks for your review. /cc @coderschoolreview

I've fix those bugs and add some more (you can quickly take a look on new gif)

• Change the login page: apply the animation thing we learn this week :)
• Add infinite load
• User can delete their posts, or hide other posts
• Show image: ONLY 1st image will be shown

[coderschoolreview]

:100: thanks for the updates!

• love the creative touch on login
• nice work with smooth infinite loading
• love the swipe-left to hide/delete
• tweet images work well with autolayout -- nice job with dynamic constraint again

one minor bug when replying. placeholder text is still there:

you have a few constraint ambiguities. when i scroll down, i see some constraint warnings in the log (view seems fine)

2015-12-05 18:02:32.332 BlueBird[29092:3511704] Unable to simultaneously satisfy constraints.
    Probably at least one of the constraints in the following list is one you don't want. 
    Try this: 
        (1) look at each constraint and try to figure out which you don't expect; 
        (2) find the code that added the unwanted constraint or constraints and fix it. 
(
    "<NSLayoutConstraint:0x7fae80cba2c0 V:[UIButton:0x7fae80cba030(0)]>",
    "<NSLayoutConstraint:0x7fae80cbaf20 V:[UIButton:0x7fae80cbac90(18)]>",
    "<NSLayoutConstraint:0x7fae80cbba70 V:[UIImageView:0x7fae80cbb8c0(135)]>",
    "<NSLayoutConstraint:0x7fae80cbc460 V:[UIButton:0x7fae80cba030]-(0)-[UIImageView:0x7fae80cb84f0]>",
    "<NSLayoutConstraint:0x7fae80cbc500 V:|-(8)-[UIButton:0x7fae80cba030]   (Names: '|':UITableViewCellContentView:0x7fae80cb76d0 )>",
    "<NSLayoutConstraint:0x7fae80cbc5a0 UILabel:0x7fae80cb7860'Forbes'.top == UIImageView:0x7fae80cb84f0.top>",
    "<NSLayoutConstraint:0x7fae80cbc730 V:[UILabel:0x7fae80cb7860'Forbes']-(3)-[UILabel:0x7fae80cbb4c0'\"The Crimson Flame\" sold ...']>",
    "<NSLayoutConstraint:0x7fae80cbc780 V:[UILabel:0x7fae80cbb4c0'\"The Crimson Flame\" sold ...']-(3)-[UIImageView:0x7fae80cbb8c0]>",
    "<NSLayoutConstraint:0x7fae80cbc960 V:[UIButton:0x7fae80cbac90]-(>=5)-|   (Names: '|':UITableViewCellContentView:0x7fae80cb76d0 )>",
    "<NSLayoutConstraint:0x7fae80cbca00 V:[UIImageView:0x7fae80cbb8c0]-(0)-[UIButton:0x7fae80cbac90]>",
    "<NSLayoutConstraint:0x7fae80cc7590 'UIView-Encapsulated-Layout-Height' V:[UITableViewCellContentView:0x7fae80cb76d0(109)]>"
)

Will attempt to recover by breaking constraint 
<NSLayoutConstraint:0x7fae80cbba70 V:[UIImageView:0x7fae80cbb8c0(135)]>

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.

In more complicated cases, you may want to look up the Visual Format Language syntax on https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/AutolayoutPG/VisualFormatLanguage.html

For this case, however, there is a conflict between the original image constraint from IB and the dynamic constraint set when there is an image. Just set the image height layout 135 to lower priority (e.g. 750 instead of 1000).

Consider setting content compression resistance priority higher in your your username or fullname because right now they are the same and result in inconsistent behavior for different cells: