XML Signature element is after signedObject in response which is not valid

avob / OpenADR

OpenADR protocol java implementation: https://www.openadr.org/

Apache License 2.0

50 stars 23 forks source link

XML Signature element is after signedObject in response which is not valid #27

Open bpair opened 1 year ago

bpair commented 1 year ago

Is anybody still using this project? It is really impressive. I was trying to use an OpenLEADR VEN with this running as a VTN but getting xml signature issues. I noticed in the response the order violates the schema.

bpair commented 1 year ago

This is a quick fix in OadrXMLSignatureHandler: DOMSignContext dsc = new DOMSignContext(privateKey, oadrPayloadNode); // manipulate java signature generation to conform to oadr expectation dsc.setDefaultNamespacePrefix("xmldsig"); dsc.setNextSibling(oadrPayloadNode.getFirstChild());

zanni commented 1 year ago

Hi,

Sorry I do not have time right now to maintain and upgrade this project but feel free to push a merge request and I will merge it into master.