search

avocado-framework / aexpect

Python library used to control interactive programs
GNU General Public License v2.0
8 stars 32 forks source link

Fix remote_door set_subcontrol_* handling of no matches #103

Closed ldoktor closed 2 years ago

ldoktor commented 2 years ago

In case the parameter is not found we need to return immediately, otherwise we'd be replacing everything with our parameter.

This was introduced in https://github.com/avocado-framework/aexpect/pull/101 and was the source of the selftest hangs.

ldoktor commented 2 years ago

@pevogam could you please verify my fix is correct? IIUC the code should perform no modifications in case the parameter was not set in the original subcontrol file, right? In that case we should not need to run any replacement and simply return.

pevogam commented 2 years ago

@ldoktor Nice catch! Is this the reason why the CI was hanging? I thought it was a problem on the GH actions side and never looked deeper into it. I guess the lesson to be learned is that we should always check the CI status even if it is potential noise from external problems. Will include this into some quick end-to-end testing on our side and ACK the pull request as soon as it completes. Thanks!

ldoktor commented 2 years ago

Thank you for the review. Let me merge this and re-run the other PR checks.