search

avocado-framework / avocado-vt

Avocado VT Plugin
https://avocado-vt.readthedocs.org/
Other
83 stars 241 forks source link

utils_net.py: add dhcp client detection #3949

Closed quanwenli closed 1 month ago

quanwenli commented 1 month ago
  1. detect available dhcp clients (dhclient, dhcpcd)
  2. configure release command base on detected client

Signed-off-by: Wenli Quan wquan@redhat.com

id: 2628

quanwenli commented 1 month ago

@YongxueHong could. you help review it ? thanks a lot.

YongxueHong commented 1 month ago

Hi @PaulYuuu @zhenyzha @yanglei-rh @fbq815 Could you help to review if this PR affects your platform? Thanks in advance.

zhenyzha commented 1 month ago

LGTM.Acked-by: Zhenyu Zhang zhenyzha@redhat.com

Sending command (safe): ifconfig eth0 up; dhclient -r; dhclient eth0

 (1/2) qemu.set_link.reboot_shell.before_guest_boot_up.arm64-pci: PASS (172.26 s)
 (2/2) qemu.set_link.reboot_system_reset.before_guest_boot_up.arm64-pci: PASS (163.11 s)
YongxueHong commented 1 month ago

Hi @quanwenli Could you share further details of the reason for this PR? And I recommend adding it to the commit message. Thanks.

quanwenli commented 1 month ago

Hi @quanwenli Could you share further details of the reason for this PR? And I recommend adding it to the commit message. Thanks.

I have added the reason in commit. thanks