misanjumn
commented
2 weeks ago Explanation
This particular piece of code checks the presence of "kernel_args" parameter in the output of virt-install --boot help
if has_sub_option("boot", "kernel_args") and kernel_args:
result += 'kernel_args="%s",' % kernel_argsBut the output of virt-install --boot help does not contain "kernel_args" as sub option. Hence the above check is not satisfied even if the "kernel_args" parameter is being passed in the config file
# virt-install --boot help
--boot options:
clearxml
xpath[0-9]*.create
xpath[0-9]*.delete
xpath[0-9]*.set
xpath[0-9]*.value
acpi.table
acpi.table.type
arch
bios.rebootTimeout
bios.useserial
boot[0-9]*.dev
bootloader
bootloader_args
bootmenu.enable
bootmenu.timeout
cdrom
cmdline
domain_type
dtb
emulator
fd
firmware
firmware.feature[0-9]*.enabled
firmware.feature[0-9]*.name
hd
init
initarg[0-9]*
initargs
initdir
initenv[0-9]*
initenv[0-9]*.name
initgroup
initrd
inituser
kernel
loader
loader.readonly
loader.secure
loader.type
machine
network
nvram
nvram.template
os_type
refresh-machine-typeThis is because, "cmdline" is the recommended way of passing the kernel command line parameters Reference: https://github.com/virt-manager/virt-manager/commit/d85a9a4808e6d5116ae0dd2b7e321bd1491447bc#diff-a207f1f755d446ad85f8fc53a1a14646999f56c7be124b356c78d601aea62429
harihare
PraveenPenguin
libvirt-vm: Add support for cmdline parameter for --boot
Currently, kernel_args is not present in the output of "virt-install --boot help" as "--boot cmdline=%s" is the recommended way of passing kernel command line parameters. As a result, the import/install test is failiing since kernel and initrd parameter is being passed without kernel_args
But --boot option supports both kernel_args and cmdline parameter for passing kernel arguments to the guest, i.e,
--boot kernel=<vmlinuz>,initrd=<initrd>,cmdline=<kernel-cmdline>(recommended way) (or)--boot kernel=<vmlinuz>,initrd=<initrd>,kernel_args= <kernel-cmdline>This patch adds support of reading both cmdline and kernel_args parameter and passes whichever is available from config to the virt-install --boot option
Signed-off-by: Misbah Anjum N misanjum@linux.vnet.ibm.com