search

avocado-framework / avocado-vt

Avocado VT Plugin
https://avocado-vt.readthedocs.org/
Other
84 stars 243 forks source link

Update cpu_model_flags value #3988

Closed leidwang closed 2 months ago

leidwang commented 2 months ago

Currently, cpu_model_flags's value is missing ',', it may cause the issue that cpu_model_flags's can be parsed correctly.

ID: 2819

leidwang commented 2 months ago

Hi @YongxueHong Would you please help review it when you have time?Thanks!

YongxueHong commented 2 months ago

Hi @XueqiangWei , @peixiu , @fbq815 , @lkotek , @yanan-fu Could you help to review it? Thanks in advance.

fbq815 commented 2 months ago

seems the change won't influence s390x, could skip this time

lkotek commented 2 months ago

LGTM :+1: I am fine with the change, thanks!

yanan-fu commented 2 months ago

Approve after check the whole logic.

To be safe for all, every += for cpu_model_flags can (need) start with , based on the cpu flag parse rule[1] and the rule of adding cpu flag in command line [2][3].

[1] https://github.com/avocado-framework/avocado-vt/blob/f0424ee74f6e3043327bd38fa069bac1c1a075f6/virttest/cpu.py#L1457 [2] https://github.com/avocado-framework/avocado-vt/blob/f0424ee74f6e3043327bd38fa069bac1c1a075f6/virttest/env_process.py#L1431 [3] https://github.com/avocado-framework/avocado-vt/blob/f0424ee74f6e3043327bd38fa069bac1c1a075f6/virttest/qemu_vm.py#L1470

peixiu commented 2 months ago

(11/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_time.q35: STARTED (11/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_time.q35: PASS (502.87 s) (12/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_crash.q35: STARTED (12/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_crash.q35: PASS (366.60 s) (13/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_reset.q35: STARTED (13/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_reset.q35: PASS (197.27 s) (14/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_tlbflush.q35: STARTED (14/28) Host_RHEL..u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.hv_tlbflush.q35: PASS (906.57 s)

LGTM! Acked-by: Peixiu Hou phou@redhat.com

YongxueHong commented 2 months ago

Hi @XueqiangWei Could you help to review it? Just a kindly reminder. Thanks in advance.