search

avocado-framework / avocado

Avocado is a set of tools and libraries to help with automated testing. One can call it a test framework with benefits. Native tests are written in Python and they follow the unittest pattern, but any executable can serve as a test.
https://avocado-framework.github.io/
Other
336 stars 335 forks source link

Hardcoded nrunner removal in TestSuite #5955

Closed richtja closed 3 weeks ago

richtja commented 3 weeks ago

This is a removal of left over of legacy code. When avocado supported legacy and nrunner runners we also distinguished between resolver resolution and test load. When the legacy runner has been removed, we don't have this issue anymore, because resolvers are only supported implementation of test resolution. Unfortunately, we kept validation of supported runners during the test reference resolution with hardcoded nrunner. This is wrong because nrunner is a SuiteRunner plugin, and it can be replaced by any installed SuiteRunner.

Reference: #5954

richtja commented 3 weeks ago

Hi @pevogam, when you will have time, can you please check if this fixes your issue in #5954, thank you.

pevogam commented 3 weeks ago

Hi @pevogam, when you will have time, can you please check if this fixes your issue in #5954, thank you.

Hi @richtja, but I don't understand - is this run.suite_runner config option now deprecated? Because the diff in the fix simply seems to remove it.

richtja commented 3 weeks ago

Hi @pevogam, when you will have time, can you please check if this fixes your issue in #5954, thank you.

Hi @richtja, but I don't understand - is this run.suite_runner config option now deprecated? Because the diff in the fix simply seems to remove it.

Hi @pevogam, no it is not deprecated, the suite_runner is selected at different place. This code can be removed, because we had it only for distinguishing between legacy loader and nrunner resolver. Actually, this part of the code has nothing to do with the suite_runner itself, and therefore it can be removed. For more information about this, you can look into last LTS version with the legacy runner.