search

avocado-framework / avocado

Avocado is a set of tools and libraries to help with automated testing. One can call it a test framework with benefits. Native tests are written in Python and they follow the unittest pattern, but any executable can serve as a test.
https://avocado-framework.github.io/
Other
345 stars 343 forks source link

Method modification for obtaining container information #5974

Closed ut003460 closed 4 months ago

ut003460 commented 5 months ago

1.Exception message improvement Change the f "Failed getting information about container:" f "{container_id}." that concatenates two strings together to a single string to avoid unnecessary string concatenation 2.Replace container ["Id"] with container. get ("Id") to avoid throwing KeyError when the "Id" key is missing in the dictionary

ut003460 commented 4 months ago

Okay, thank you for your suggestion. I have resubmitted it

richtja commented 4 months ago

Okay, thank you for your suggestion. I have resubmitted it

Hi @ut003460, is there any reason for removing your changes instead of splitting them into two commits as @clebergnu proposed?

ut003460 commented 4 months ago

Okay, thank you for your suggestion. I have resubmitted it

Hi @ut003460, is there any reason for removing your changes instead of splitting them into two commits as @clebergnu proposed?

Okay, maybe I misunderstood. Could you please check if this submission is correct?