Add exception handling to os.remove in the remove-asset-by_pathfang method of the avocado/utilities/asset.py file

avocado-framework / avocado

Avocado is a set of tools and libraries to help with automated testing. One can call it a test framework with benefits. Native tests are written in Python and they follow the unittest pattern, but any executable can serve as a test.

https://avocado-framework.github.io/

Other

345 stars 343 forks source link

Add exception handling to os.remove in the remove-asset-by_pathfang method of the avocado/utilities/asset.py file #5979

Closed faker-king closed 2 months ago

faker-king commented 5 months ago

Using pathlib can make file path operations more object-oriented and easy to understand, and have better compatibility across different operating systems.

mr-avocado[bot] commented 5 months ago

Dear contributor, Avocado is currently at the end of sprint #106, therefore we are in feature freeze state. Please avoid merging changes that do not fall into these categories:

Bug fixes
Documentation updates

The feature freeze will be active until the release planned on 28 June 2024.

faker-king commented 4 months ago

hi @richtja, Can you help me see if I can merge the code

faker-king commented 4 months ago

Hi @richtja, I am very sorry for the delay in modifying this PR. I have already made the necessary changes as per your request. Could you please double check.

faker-king commented 2 months ago

@richtja Due to some permission issues with my account, it was verified and I have made the necessary modifications as per your suggestion to see if it can be merged

richtja commented 2 months ago

Hi @faker-king, thank you for your updates. I'm still missing the commit title update, your changes don't add exception handling to os.remove in the whole avocado project, it is located only to avocado/utils/asset.py. Can you please update the title to be more specific? Thank you.

faker-king commented 2 months ago

@richtja Modified

richtja commented 2 months ago

@richtja Modified

Hi @faker-king, sorry but maybe I haven't expressed myself clearly, I was talking about commit headline. It is needed for easier search thought changes in commit history in the future. Can you please update the commit headline as well, thanks.

faker-king commented 2 months ago

@richtja Haha, it's okay, I didn't understand either, it has been modified.