search

avocado-framework / inspektor

Inspektor code checker
Other
11 stars 17 forks source link

Bug fix and code update for github pr check #19

Closed will-Do closed 8 years ago

will-Do commented 8 years ago
  1. github: Fix missing argument bug for github pull request checker Now classes Linter, Reindenter, StyleChecker and PathInspector all have the 'args' argument to pass cli arguments, but it's missed when do github pull request. And by fix this issue, it's also need add corresponding arguments for subcommand 'github'.
  2. process.run: Allow run shell command in subprocess
  3. Update getting parent project and repo name method By adding a '--parent-project' argument, now inspektor can check github pull request beyond 'autotest'. And as not all repos using the same style to write LICENSE, so change the way to get repo name.
lmr commented 8 years ago

The changes look good, I'm going to merge this and fix the small typo later. Thanks @will-Do !