search

avocado-framework / inspektor

Inspektor code checker
Other
11 stars 17 forks source link

'PatchChecker' object has no attribute 'confirm' #2

Closed ldoktor closed 10 years ago

ldoktor commented 10 years ago

Hi @lmr, I'm in the middle of review so instead of fix I'm filling this issue:

[medic@t530 io-github-autotest-qemu 130]$ inspekt github 31
Fetching https://github.com/autotest/tp-qemu/pull/31.patch -> /tmp/github-31.patch
Repository has changed files prior to patch application
Traceback (most recent call last):
  File "/usr/bin/inspekt", line 14, in 
    app.run()
  File "/usr/lib/python2.7/site-packages/inspektor/cli/app.py", line 62, in run
    self.args.func(self.args)
  File "/usr/lib/python2.7/site-packages/inspektor/check.py", line 236, in check_patch_github
    checker = PatchChecker(github_id=gh_id)
  File "/usr/lib/python2.7/site-packages/inspektor/check.py", line 145, in __init__
    auto=self.confirm)
AttributeError: 'PatchChecker' object has no attribute 'confirm'

You have the self.confirm in the docstring, but it's not initialized...

lmr commented 10 years ago

Closing this issue, as it was fixed by #3.