search

avocado-framework / inspektor

Inspektor code checker
Other
11 stars 17 forks source link

Reenable E402 and support for multiple paths #9

Closed ldoktor closed 9 years ago

ldoktor commented 9 years ago

Hi @lmr,

I looked again at the E402 problem and the latest PEP8 update fixes the issue with E402 being incorrectly detect by PEP8 when used as module. I think we should re-enable it again (there are couple of nasty modules in avocado, thought, but no false-positives).

The second commit is because I had my git rerere poisoned by inspektor. It's really better to use git ls-files and check only the ones which are in this repository, rather than full recursive check.

Kind reagards, Lukáš

ldoktor commented 9 years ago

OK, removing the inspektor.style as we use magic to insert sys.path in some of the files and PEP8 doesn't support per-error in-code mask. Anyway the detection works fine now...

ldoktor commented 9 years ago

@lmr what do you say about the multi-path support?

lmr commented 9 years ago

Oh, true. I think it's great. I'm going to re-read the patch and merge soon enough.

lmr commented 9 years ago

Looks good. Let me test this here.

lmr commented 9 years ago

Thanks @ldoktor !

lmr commented 9 years ago

Now, directory scan has to be fixed.

ldoktor commented 9 years ago

What is wrong with the directory scan?

lmr commented 9 years ago

From your commit comment:

 The problem with directory scan is it descends to submodules and also corrupts the "git rerere" cache.
ldoktor commented 9 years ago

Well I'm not sure you have an easy way to fix this. You can either skip .git directories, or skip all hidden directories or just leave it on the users....

lmr commented 9 years ago

Yep, I'm looking at ignoring .git directories.

ldoktor commented 9 years ago

One could argue, how about .svn, ...