search

avoidwork / filesize.js

JavaScript library to generate a human readable String describing the file size
https://filesizejs.com
BSD 3-Clause "New" or "Revised" License
1.61k stars 97 forks source link

Replace build system with rollup #124

Closed realityking closed 3 years ago

realityking commented 3 years ago

Also includes the changes from #121.

This PR replaces grunt with a with package scripts based build system. The same version of the nodeunit-x and eslint are used, those upgrades can be handled later separately.

More importantly, this PR changes the build tool to rollup. Right now rollup is configured to create exactly the same files as they're currently shipping but with a tiny size saving (lib/filesize.es6.min.js is 12 bytes smaller). However rollup has a lot of potential to ship more efficient builds using CommonJS and ESM that I'd like to propose in a follow-up PR.

Fixes #123 Fixes #124

realityking commented 3 years ago

@avoidwork Can you take a look a this PR? 🙏

avoidwork commented 3 years ago

@realityking thanks a lot for taking care of this! shipped as 6.2.0.