avoidwork / filesize.js

JavaScript library to generate a human readable String describing the file size
https://filesizejs.com
BSD 3-Clause "New" or "Revised" License
1.61k stars 97 forks source link

Update symbols for bits to "bit" #136

Closed getsnoopy closed 3 years ago

getsnoopy commented 3 years ago

The international symbol for the bit is "bit", not "b", which was deprecated a while ago. This commit updates the symbol accordingly.

avoidwork commented 3 years ago

I'm not sure if you realized this but the lib defaults to traditional binary, and allows you to run anything you want... there's even a partial application to keep it low waste.

"bit" and "b" are interchangable. I'm well aware of SI. I'm Canadian.

avoidwork commented 3 years ago

https://en.wikipedia.org/wiki/Bit#:~:text=The%20symbol%20for%20the%20binary,the%20IEEE%201541%2D2002%20standard.

getsnoopy commented 3 years ago

"bit" and "b" are interchangable

b is only valid in IEEE, but bit causes far less confusion. Why not just use the less confusing one?

avoidwork commented 3 years ago

This is your opinion.

getsnoopy commented 3 years ago

I guess, but seeing as many people do not know that the symbols are case sensitive, there are people who read things like "Mbps" or "Mb/s" as "megabytes per second". This is far less likely, if not essentially impossible, to do when the symbol reads "Mbit/s". I don't see what the resistance is about with changing this when it's so easy to change and clearly reduces confusion.

getsnoopy commented 3 years ago

Could you merge this in?