search

avoidwork / filesize.js

JavaScript library to generate a human readable String describing the file size
https://filesizejs.com
BSD 3-Clause "New" or "Revised" License
1.61k stars 97 forks source link

Make SI and IEC standards defaults #138

Closed getsnoopy closed 3 years ago

getsnoopy commented 3 years ago

This commit makes the SI standard (base 10) the generic default, and the IEC standard the default for base-2 formatting in order to make it as intuitive as possible, to reduce any ambiguity, and to mirror the industry standard.

Fixes #137

avoidwork commented 3 years ago

@getsnoopy I don't want to make SI default; just IEC if you feel it needs to change. There's millions of projects using this directly and indirectly, and base 2 to 10 would impact them.

avoidwork commented 3 years ago

merged it anyways, 'cause this should happen (aka 2.0.0).

getsnoopy commented 3 years ago

This would be a major version bump, so no one currently using this would be affected by it; only new users.