avoidwork / filesize.js

JavaScript library to generate a human readable String describing the file size
https://filesizejs.com
BSD 3-Clause "New" or "Revised" License
1.61k stars 97 forks source link

feat: infer result type correctly with TypeScript (no "npx tsc") #144

Closed tomoto closed 2 years ago

tomoto commented 2 years ago

Hello, thank you for looking at my previous PR #142 and my apologies that I was not aware "npx tsc" had an issue (as pointed out in https://github.com/avoidwork/filesize.js/pull/142#issuecomment-950324141 ). I am posting a new PR without "npx tsc".

This PR is exactly the same as my previous PR except:

I believe now npm test should pass as expected. I appreciate your effort. Thank you very much.

avoidwork commented 2 years ago

Thanks, this is 8.0.4.