search

avoidwork / filesize.js

JavaScript library to generate a human readable String describing the file size
https://filesizejs.com
BSD 3-Clause "New" or "Revised" License
1.61k stars 97 forks source link

Not compatible with Node.js v12? #168

Closed medikoo closed 1 year ago

medikoo commented 1 year ago

Recently following the CHANGELOG, I've upgraded filesize from v8 to v10.

There are no notes in CHANGELOG that support for Node.js v12 was dropped. Yet suddenly, I got a report from a user stating that you log a warning that Node.js v12 is not supported. Is that the case?

If it's the case, can you indicate that in the CHANGELOG file to avoid further confusion (?) Otherwise, can you update the warning notice so it doesn't scream at Node.js v12 users

avoidwork commented 1 year ago

The lib doesn't emit such a message, but I can lower the engine to 10.0.0 because it has bigint support.

The changelog is generated, it's hard to guess what would matter to a person in the future when considering my writing style.

medikoo commented 1 year ago

@avoidwork npm emits that message based on metadata in package.json. Also, you've already fixed that once: https://github.com/avoidwork/filesize.js/issues/161 :)

avoidwork commented 1 year ago

@medikoo this is fixed with 10.0.6, such that 10.4.0 is the minimum version.

Regarding min version... I moved it from 0.4.0 to current stable after 11 years, it's interesting to see what products are using what versions due to RTE, etc..