Closed nwalters512 closed 1 year ago
what's the best course of action for typescript users? i can revert, but I'm not going to produce a fix.
i've reverted 10.0.9 to produce 10.0.10 (equal to 10.0.8).
cc @tschlechtweg
I overlooked that case. @nwalters512 please go ahead and create a PR with the changes you proposed, please also don't forget to then change the overloads of the partial
-function.
I've reverted 10.0.9 as 10.0.10/11 (ugh) so please correct and open a new PR.
172 appears to disallow passing an
options
object without also specifying anoutput
property. This can be reproduced with the following code:TypeScript playground link: https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgM2AGwKYGdgC8NwC+KUEIcA5KpjvhQNwCwAUCwMYQB2W8tBAvCnTY8GABQBGAEwBmACwBWADSI4AIwCGWDAC44UogEp6QA
If this was intentional, this should be released in a v11, as it was a breaking change. However, based on the docs, I can assume this was unintentional, as
output
is specified as having a default ofstring
, and it isn't explicitly passed in the example at the top of theREADME
. If this was indeed unintentional, I can open a PR making the following change to the types: