search

avoidwork / filesize.js

JavaScript library to generate a human readable String describing the file size
https://filesizejs.com
BSD 3-Clause "New" or "Revised" License
1.61k stars 97 forks source link

There should be a space between the number and the units. #32

Closed NodeGuy closed 11 years ago

NodeGuy commented 11 years ago

The International System of Units, or SI,[19] and the style guide on the English-language Wikipedia[20] recommend a (non-breakable, thin) space between a number and its units, as well as between units in the case of compound units, but never between the prefix of an SI unit and the unit.

   45 kg not 45kg or 45 k g

source: http://en.wikipedia.org/wiki/Space_%28punctuation%29#Spaces_and_unit_symbols

avoidwork commented 11 years ago

This will be available (in 1.9.4) as soon as the travis-ci.org builds are functional again. The shorthand output will not adhere to this, and continue to follow the ls -h output.

NodeGuy commented 11 years ago

Thank you.

avoidwork commented 11 years ago

You're welcome. I also added a lint step to the build process, and a sourcemap.

NodeGuy commented 11 years ago

Nice! BTW, I dig http://filesizejs.com/, very pretty.