search

avonar / impacket

Automatically exported from code.google.com/p/impacket
Other
0 stars 0 forks source link

VLAN tagging (IEEE 802.1Q and 802.1ad) #24

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I would like to suggest a new feature. It would be nice if Impacket recognized 
IEEE 802.1Q tags and provided interface to inspect them conveniently.

Currently, ImpactPacket.Ethernet does not check for the presence of tags. If 
present, a wrong header size and EtherType are reported, which causes 
EthDecoder to overlook higher protocol layers. The user is left with an 
Ethernet instance containing an ImpactPacket.Data child.

The attached solution extends ImpactPacket.Ethernet with methods managing the 
tag stack (get, set, push, pop) and modifies load_header, get_header_size and 
get/set_ether_type accordingly. The tag getters/setters works with instances of 
EthernetTag, which provide access to the tags' fields. A unit test is included.

Original issue reported on code.google.com by dan.p...@gmail.com on 12 May 2013 at 4:55

Attachments:

GoogleCodeExporter commented 9 years ago 
Dan:

Thanks very much for the contribution!. I just applied the patches (and unit 
test) you sent me and committed it to trunk ( 
http://code.google.com/p/impacket/source/detail?r=760 ).

Please verify everything's working as expected on your side.

cheers,
beto

Original comment by bet...@gmail.com on 13 May 2013 at 6:18