search

avonni / base-components

MIT License
38 stars 14 forks source link

feature-ABC-966-image-compare-slider #598

Closed Jusolijus17 closed 1 year ago

Jusolijus17 commented 1 year ago

Features

Image

Jusolijus17 commented 1 year ago

Fixes:

  • We shouldn't see the magnifier in this pull request, since this feature was made in another branch. Please remove anything regarding the magnifier, and merge the master branch in this branch to resolve the remaining conflicts. 🙂
  • Right now the tests don't pass.
  • See also my comment on Jira's task.

Documentation:

  • The compare attributes need to be documented. You need to add a @typedef block in the image.jsdoc.js file. See Documenting Objects in our documentation.

Improvements:

  • Can you make it work on touch screens?
  • Can you make it work with the keyboard?

@nawel-aa How do you imagine it working with a keyboard? Using the arrow keys, I guess? But if so, you would still need to first select the image in order to focus on it and then use the right arrow key, right?

nawel-aa commented 1 year ago

@nawel-aa How do you imagine it working with a keyboard? Using the arrow keys, I guess? But if so, you would still need to first select the image in order to focus on it and then use the right arrow key, right?

Yes, I created a subtask to explain in more details what I have in mind. 😊