avored / laravel-ecommerce

AvoRed an Open Source Laravel Shopping Cart
https://avored.com
1.52k stars 549 forks source link

Banner Issue #393

Open yoyoypy opened 5 years ago

yoyoypy commented 5 years ago

Ideally we would expect you to raise a bug on AvoRed Official Website https://www.avored.com/discussion/category/general

Describe the bug When showing banner, product list will dropped to bottom of page

To Reproduce Steps to reproduce the behavior:

  1. Upload Banner
  2. Go to home page

Screenshots Screenshot_19 Screenshot_20

Desktop (please complete the following information):

indpurvesh commented 5 years ago

@yoyoypy Sorry i don't really understand what is the bug?I don't really see the image

yoyoypy commented 5 years ago

this view without banner

Screenshot_25

but when i add banner, there is massive gap/space between banner section and product card

Screenshot_26 Screenshot_27 Screenshot_28

btw where is css file for avored? maybe i can modify little bit for this issue...

indpurvesh commented 5 years ago

I have feeling that there is a JS compilation issue. Take a look at this docs https://laravel.com/docs/6.x/mix#custom-webpack-configuration

css Location: resources/less/app.less

run the below command to start compiling (webpack.mix.js ):

 npm install
 npm run watch
yoyoypy commented 5 years ago

npm install npm run watch

this command didnt solve the problem, still get blank gap/space between banner and product list..

i think problem here, i will look it up Screenshot_29

yoyoypy commented 5 years ago

after removing height its become normal looks. still searching where height come from

Screenshot_30

marol1210 commented 4 years ago

@yoyoypy have many banner items , each item dimension need equally

you can substitute your widget for basic widget

modules/avored/banner/resources/views/widget/index.blade.php

image

indpurvesh commented 4 years ago

@yoyoypy i am using vue ant design component. Try reading thier docs it might help you.

https://www.antdv.com/

If not you can always override the blade.view file.