search

avr-llvm / llvm

[MERGED UPSTREAM] AVR backend for the LLVM compiler library
220 stars 21 forks source link

Compile again, after tracking upstream changes #191

Closed shepmaster closed 8 years ago

shepmaster commented 8 years ago

We should probably look closer at 9ed38db20eac20ba78c7daf6970324612cd0d60f to see if we can follow those changes closely.

shepmaster commented 8 years ago

@dylanmckay Heads-up; I'm also fixing the Travis support here.

dylanmckay commented 8 years ago

Nice, travis support would be good to have back :)

shepmaster commented 8 years ago

@dylanmckay 💚

shepmaster commented 8 years ago

And because that was ambiguous, I mean that the build is green again.

dylanmckay commented 8 years ago

Nice work!

Is this ready to be reviewed?

shepmaster commented 8 years ago

Is this ready to be reviewed?

Yep! I'm sure there are better ways of making the fixes.

shepmaster commented 8 years ago

Is this ready to be reviewed?

And for what it's worth, I'm always happy to get reviews as soon as I submit a PR, even if the PR shouldn't be merged yet. Earlier feedback means fixing dumb things earlier 😈

shepmaster commented 8 years ago

@dylanmckay anything else you'd like fixed up?

dylanmckay commented 8 years ago

Looks good to me :) merging now I'll leave you to do it in case you want to squash or anything.

shepmaster commented 8 years ago

I'll leave you to do it

I don't have merge rights on this repository, only avr-rust :-) I'm OK with the granularity of the commits though. I assume you will have to figure out how they get upstreamed anyway.