search

avr-rust / delay

arduino-like delay routines based on busy-wait loops
Apache License 2.0
15 stars 11 forks source link

Use built-in target #25

Closed n8henrie closed 2 years ago

n8henrie commented 2 years ago

The built-in target works well and would make a reasonable default.

stappersg commented 2 years ago

There are other microcontrollors with AVR instruction set as the atmega328p.

n8henrie commented 2 years ago

Sorry, can you make the issue more concrete?

I see the benefit here being that users of a very common microcontroller don't need to explicitly set the target with a separate json file, because a functional target its now built-in to rustc. Users of other or incompatible microcontrollers can continue doing what they currently do by using a separate json config file, but the default case will be simpler.

What do you see as the downside? EDIT: In concrete terms, what current workflow or use case would break or be made more difficult than the existing situation?

stappersg commented 2 years ago

Make a new merge request. Same as this MR. The difference should be that avr-atmega328p.json is not removed.

(Karma bonus points for a more neutral commit message.)

n8henrie commented 2 years ago

Make a new merge request.

Couldn't I just fix that issue within this PR?

n8henrie commented 2 years ago

Karma bonus points for a more neutral commit message.

The commit message is fairly bland. Did you mean the body of the pull request (at the top of this page)? If so, I have edited that, restored the json file, and squashed the commits. Does this look okay?