avrae / draconic

The Draconic language: a scripting language based off Python to run user scripts on the server safely.
MIT License
18 stars 9 forks source link

Blackify Repo #18

Closed zhudotexe closed 2 years ago

zhudotexe commented 2 years ago

Summary

This PR adopts the Black preview code style for this project with line-length 120.

Checklist

PR Type

codecov[bot] commented 2 years ago

Codecov Report

Merging #18 (f69b3e1) into master (59dbcd3) will not change coverage. The diff coverage is 96.66%.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files           8        8           
  Lines        1073     1073           
=======================================
  Hits         1057     1057           
  Misses         16       16           
Impacted Files Coverage Δ
draconic/interpreter.py 98.24% <91.66%> (ø)
draconic/helpers.py 100.00% <100.00%> (ø)
draconic/string.py 95.91% <100.00%> (ø)
draconic/types.py 98.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59dbcd3...f69b3e1. Read the comment docs.

Croebh commented 2 years ago

No precommit?

zhudotexe commented 2 years ago

Nah, I'm not a fan of the precommit since it makes certain git clients (like GH Desktop) unhappy when files change after you click commit, plus each contributor has to manually install the precommit hook themselves. IMO it's smoother to have a lint workflow notify the developer to blackify their code.