avrae / draconic

The Draconic language: a scripting language based off Python to run user scripts on the server safely.
MIT License
18 stars 9 forks source link

getattr weirdness is now contained #25

Closed LazyDope closed 1 year ago

LazyDope commented 1 year ago

Summary

The interpreter silently getting items when you asked for an attribute was sorta weird, so now it's an inherent part of SafeDict's getattr method instead. This quirk was undocumented already, so I'm not really sure where it should be documented now.

Checklist

PR Type

codecov[bot] commented 1 year ago

Codecov Report

Base: 98.67% // Head: 98.53% // Decreases project coverage by -0.13% :warning:

Coverage data is based on head (b01086e) compared to base (557cf64). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #25 +/- ## ========================================== - Coverage 98.67% 98.53% -0.14% ========================================== Files 8 6 -2 Lines 1130 1094 -36 ========================================== - Hits 1115 1078 -37 - Misses 15 16 +1 ``` | [Impacted Files](https://codecov.io/gh/avrae/draconic/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avrae) | Coverage Δ | | |---|---|---| | [draconic/interpreter.py](https://codecov.io/gh/avrae/draconic/pull/25/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avrae#diff-ZHJhY29uaWMvaW50ZXJwcmV0ZXIucHk=) | `98.40% <100.00%> (-0.17%)` | :arrow_down: | | [draconic/types.py](https://codecov.io/gh/avrae/draconic/pull/25/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avrae#diff-ZHJhY29uaWMvdHlwZXMucHk=) | `98.37% <100.00%> (+0.03%)` | :arrow_up: | | [draconic/utils.py](https://codecov.io/gh/avrae/draconic/pull/25/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avrae#diff-ZHJhY29uaWMvdXRpbHMucHk=) | | | | [draconic/\_\_init\_\_.py](https://codecov.io/gh/avrae/draconic/pull/25/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avrae#diff-ZHJhY29uaWMvX19pbml0X18ucHk=) | | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avrae). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avrae)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.