search

avrdudes / avr-libc

The AVR-LibC package provides a subset of the standard C library for AVR 8-bit RISC microcontrollers.
https://avrdudes.github.io/avr-libc/
Other
260 stars 57 forks source link

[patch #9543] Add avrxmega3 devices. #824

Closed avrs-admin closed 2 years ago

avrs-admin commented 2 years ago

Wed 17 Jan 2018 04:29:03 PM CET

file #42937: avrxmega3.patch.bz2 file #42938: avrxmega3-v2.patch.bz2 file #42939: avrxmega3-v3.patch.bz2 file #42952: avrxmega3-v4.diff.bz2 file #42956: attiny16161-disasm.txt.bz2 file #42957: avrxmega3-v5.diff.bz2 file #43034: avrxmega3-v6.diff.bz2 file #43735: avrxmega3-v7.diff.bz2 file #44476: avrxmega3-v8.diff.bz2 file #45738: avrxmega3-v9.diff.bz2 file #48974: avrxmega3-v10.diff.xz file #52286: avrxmega3-v11.diff.xz file #52334: avrxmega3-v12.diff.xz

This issue was migrated from https://savannah.nongnu.org/patch/?9543

avrs-admin commented 2 years ago

Georg-Johann Lay Wed 17 Jan 2018 04:56:18 PM CET

Changed files: [...] ChangeLog

The delta to ChangeLog is not reasonable, too much lines affected.

Usually, ChangeLog is prone to conflicts as each push is touching it; hence it might be more comfortable to supply it as plain text snipped and leave it out of the patch.

avrs-admin commented 2 years ago

Joerg Wunsch Wed 17 Jan 2018 05:12:13 PM CET

I agree with Johann's comment regarding ChangeLog, though it's not too hard to simply extract the text from the diff.

It might be the first commit in 2018, so it's going to be a completely new ChangeLog file anyway.

avrs-admin commented 2 years ago

Balint Cristian Wed 17 Jan 2018 05:14:14 PM CET

Johann, Joerg,

avrs-admin commented 2 years ago

Georg-Johann Lay Wed 17 Jan 2018 05:15:45 PM CET

With that patch, avr-libc fails to build:

Making all in avrxmega3
make[4]: Entering directory '/srv/local/gnu/build/avrlibc-trunk/avr/lib/avrxmega3'
Making all in attiny1614
make[5]: Entering directory '/srv/local/gnu/build/avrlibc-trunk/avr/lib/avrxmega3/attiny1614'
/local/gnu/install/gcc-8/bin/avr-gcc -DHAVE_CONFIG_H -I. -I../../../../../../source/avrlibc-trunk/avr/lib/avrxmega3/attiny1614 -I../../../..  -I../../../../../../source/avrlibc-trunk/common -I../../../../../../source/avrlibc-trunk/include -I../../../../include  -Wall -W -Wstrict-prototypes -mmcu=attiny1614  -mcall-prologues -Os  -MT eewr_block_xmega.o -MD -MP -MF .deps/eewr_block_xmega.Tpo -c -o eewr_block_xmega.o ../../../../../../source/avrlibc-trunk/libc/misc/eewr_block_xmega.c
../../../../../../source/avrlibc-trunk/libc/misc/eewr_block_xmega.c: In function 'eeprom_write_page':
../../../../../../source/avrlibc-trunk/libc/misc/eewr_block_xmega.c:26:13: error: 'NVM' undeclared (first use in this function)
} while ((NVM.STATUS & NVM_NVMBUSY_bm) == NVM_NVMBUSY_bm);
^~~
../../../../../../source/avrlibc-trunk/libc/misc/eewr_block_xmega.c:26:13: note: each undeclared identifier is reported only once for each function it appears in
../../../../../../source/avrlibc-trunk/libc/misc/eewr_block_xmega.c:26:26: error: 'NVM_NVMBUSY_bm' undeclared (first use in this function); did you mean 'RTC_CMPBUSY_bm'?
} while ((NVM.STATUS & NVM_NVMBUSY_bm) == NVM_NVMBUSY_bm);
^~~~~~~~~~~~~~
RTC_CMPBUSY_bm
../../../../../../source/avrlibc-trunk/libc/misc/eewr_block_xmega.c:58:13: error: 'NVM_CMD_ERASE_WRITE_EEPROM_PAGE_gc' undeclared (first use in this function)
NVM.CMD = NVM_CMD_ERASE_WRITE_EEPROM_PAGE_gc;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../../../../source/avrlibc-trunk/libc/misc/eewr_block_xmega.c:59:29: error: 'NVM_CMDEX_bm' undeclared (first use in this function); did you mean 'TCD_CMPDEN_bm'?
ccp_write_io (&NVM.CTRLA, NVM_CMDEX_bm);
^~~~~~~~~~~~
TCD_CMPDEN_bm
Makefile:632: recipe for target 'eewr_block_xmega.o' failed

Notice that avr-gcc defines AVR_XMEGA for these devices (in case that matters).

avrs-admin commented 2 years ago

Balint Cristian Wed 17 Jan 2018 06:13:17 PM CET

[1] http://distribute.atmel.no/tools/opensource/Atmel-AVR-GNU-Toolchain/3.6.1/

avrs-admin commented 2 years ago

Georg-Johann Lay Thu 18 Jan 2018 12:50:34 PM CET

Thanks, I can build avr-libc now and a quick test looks good.

Regarding the changes to eewr_block_xmega.c, maybe it's clearer to special-case the different NVM flavours instead of #define + #undef + #define chains?

I allowed me to attach a respective patch as avrxmega3-v4.diff.bz2

avrs-admin commented 2 years ago

Balint Cristian Thu 18 Jan 2018 03:07:09 PM CET

Johann,

avrs-admin commented 2 years ago

Georg-Johann Lay Thu 18 Jan 2018 04:10:27 PM CET

There must still be missing something, at least _PROTECTED_WRITE_SPM.  Apart from a build warning for a missing prototype, it's neither resolved by a macro nor my a symbol:

$ echo 'int main(){}' | avr-gcc -xc - -Wl,-u,eeprom_write_block -mmcu=attiny1616
/srv/local/gnu/install/gcc-8/bin/../lib/gcc/avr/8.0.1/../../../../avr/lib/avrxmega3/libattiny1616.a(eewr_block_xmega.o): In function `eeprom_write_block':
eewr_block_xmega.c:(.text.avr-libc+0x80): undefined reference to `_PROTECTED_WRITE_SPM'
collect2: error: ld returned 1 exit status
avrs-admin commented 2 years ago

Balint Cristian Thu 18 Jan 2018 04:53:50 PM CET

Johann,

Uploaded avrxmega3-v5.diff.bz2 .

avrs-admin commented 2 years ago

Georg-Johann Lay Thu 18 Jan 2018 05:32:53 PM CET

Ok, better now.  At least the trivial example builds now.

Some final notes on xmega.h:

Constraint "d" for [ccp_ioreg] resp. [ccp_spm_mask] could be relaxed to the less restrictive "r".

And from a strict point of view, both _PROTECTED_WRITE and _PROTECTED_WRITE_SPM are clobbering memory.

avrs-admin commented 2 years ago

Balint Cristian Fri 19 Jan 2018 11:33:27 AM CET

a) Mchip/Atmel right now mixes BSD+Apache in their packages, so avr-libc could do it too ? (not a lawyer).

b) Make new headers from scratch based from docs. A simple one (no fancy struct), just simple enumerations.

avrs-admin commented 2 years ago

Joerg Wunsch Fri 19 Jan 2018 11:42:09 AM CET

Mixing the licenses is doable, it's just a little cumbersome since we need to LICENSE documents then at the toplevel.

If #b is not too much work, it would be my personally preferred solution, as it makes us completely independent from Microchip. They've chosen to distribute their own version of the headers independently from us anyway.

avrs-admin commented 2 years ago

Balint Cristian Tue 23 Jan 2018 03:09:12 PM CET

The avrxmega3-v6.diff.bz2 includes a ATDF parser for AVR8X.

avrs-admin commented 2 years ago

jan de kruyf Fri 30 Mar 2018 06:52:28 PM CEST

Cristian, hello.

I just tried to compile avr-libc svn2546 with patches from avrxmega3-v6.diff.bz2. compiler gcc8.0.1 built for avr.

I get some errors which are at least partly from this patch. I did not get any strange messages before this just some warnings. Also the last time I built it without the patch it looked right.

Could you have a look at it?

In file included from ../../../../include/avr/io.h:456,
from ../../../../libc/misc/eewr_block_xmega.c:4:
../../../../include/avr/iotn1614.h:5623:1: error: unknown type name 'define'
define PERIOD0  (unsigned char)~_BV(0)  /* Watchdog Timeout Period Bit 0 */
^~~~~~
../../../../include/avr/iotn1614.h: In function 'PERIOD0':
../../../../include/avr/iotn1614.h:5623:32: error: expected declaration specifiers before '~' token
define PERIOD0  (unsigned char)~_BV(0)  /* Watchdog Timeout Period Bit 0 */
^
In file included from ../../../../include/avr/io.h:626,
from ../../../../libc/misc/eewr_block_xmega.c:4:
../../../../include/avr/fuse.h:234:3: error: expected declaration specifiers before '__fuse_t'
} __fuse_t;
^~~~~~~~
In file included from ../../../../include/stdlib.h:48,
from ../../../../include/assert.h:65,
from ../../../../libc/misc/eewr_block_xmega.c:8:
/home/jan/programs-8/avrada/lib/gcc/avr/8.0.1/include/stddef.h:216:23: error: storage class specified for parameter 'size_t'
typedef __SIZE_TYPE__ size_t;
^~~~~~
/home/jan/programs-8/avrada/lib/gcc/avr/8.0.1/include/stddef.h:328:24: error: storage class specified for parameter 'wchar_t'
typedef __WCHAR_TYPE__ wchar_t;
^~~~~~~
In file included from ../../../../include/assert.h:65,
from ../../../../libc/misc/eewr_block_xmega.c:8:
../../../../include/stdlib.h:73:3: error: storage class specified for parameter 'div_t'
} div_t;
^~~~~
../../../../include/stdlib.h:79:3: error: storage class specified for parameter 'ldiv_t'
} ldiv_t;
^~~~~~
../../../../include/stdlib.h:82:15: error: storage class specified for parameter '__compar_fn_t'
typedef int (*__compar_fn_t)(const void *, const void *);
^~~~~~~~~~~~~
../../../../include/stdlib.h:116:13: error: storage class specified for parameter 'abort'
extern void abort(void) __ATTR_NORETURN__;
^~~~~
../../../../include/stdlib.h:121:12: error: storage class specified for parameter 'abs'
extern int abs(int __i) __ATTR_CONST__;
^~~
../../../../include/stdlib.h:130:13: error: storage class specified for parameter 'labs'
extern long labs(long __i) __ATTR_CONST__;
^~~~
../../../../include/stdlib.h:153:61: error: expected declaration specifiers or '...' before 'size_t'
extern void *bsearch(const void *__key, const void *__base, size_t __nmemb,
^~~~~~
../../../../include/stdlib.h:154:8: error: expected declaration specifiers or '...' before 'size_t'
size_t __size, int (*__compar)(const void *, const void *));
^~~~~~
../../../../include/stdlib.h:162:14: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'div'
extern div_t div(int __num, int __denom) __asm__("__divmodhi4") __ATTR_CONST__;
^~~
../../../../include/stdlib.h:168:15: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'ldiv'
extern ldiv_t ldiv(long __num, long __denom) __asm__("__divmodsi4") __ATTR_CONST__;
^~~~
../../../../include/stdlib.h:185:33: error: expected declaration specifiers or '...' before 'size_t'
extern void qsort(void *__base, size_t __nmemb, size_t __size,
^~~~~~
../../../../include/stdlib.h:185:49: error: expected declaration specifiers or '...' before 'size_t'
extern void qsort(void *__base, size_t __nmemb, size_t __size,
^~~~~~
../../../../include/stdlib.h:186:5: error: expected declaration specifiers or '...' before '__compar_fn_t'
__compar_fn_t __compar);
^~~~~~~~~~~~~
../../../../include/stdlib.h:218:13: error: storage class specified for parameter 'strtol'
extern long strtol(const char *__nptr, char **__endptr, int __base);
^~~~~~
../../../../include/stdlib.h:252:22: error: storage class specified for parameter 'strtoul'
extern unsigned long strtoul(const char *__nptr, char **__endptr, int __base);
^~~~~~~
../../../../include/stdlib.h:264:13: error: storage class specified for parameter 'atol'
extern long atol(const char *__s) __ATTR_PURE__;
^~~~
../../../../include/stdlib.h:264:1: warning: 'pure' attribute ignored [-Wattributes]
extern long atol(const char *__s) __ATTR_PURE__;
^~~~~~
../../../../include/stdlib.h:276:12: error: storage class specified for parameter 'atoi'
extern int atoi(const char *__s) __ATTR_PURE__;
^~~~
../../../../include/stdlib.h:276:1: warning: 'pure' attribute ignored [-Wattributes]
extern int atoi(const char *__s) __ATTR_PURE__;
^~~~~~
../../../../include/stdlib.h:288:13: error: storage class specified for parameter 'exit'
extern void exit(int __status) __ATTR_NORETURN__;
^~~~
../../../../include/stdlib.h:300:21: error: expected declaration specifiers or '...' before 'size_t'
extern void *malloc(size_t __size) __ATTR_MALLOC__;
^~~~~~
../../../../include/stdlib.h:307:13: error: storage class specified for parameter 'free'
extern void free(void *__ptr);
^~~~
../../../../include/stdlib.h:312:15: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__malloc_margin'
extern size_t __malloc_margin;
^~~~~~~~~~~~~~~
../../../../include/stdlib.h:317:14: error: storage class specified for parameter '__malloc_heap_start'
extern char *__malloc_heap_start;
^~~~~~~~~~~~~~~~~~~
../../../../include/stdlib.h:322:14: error: storage class specified for parameter '__malloc_heap_end'
extern char *__malloc_heap_end;
^~~~~~~~~~~~~~~~~
../../../../include/stdlib.h:329:21: error: expected declaration specifiers or '...' before 'size_t'
extern void *calloc(size_t __nele, size_t __size) __ATTR_MALLOC__;
^~~~~~
../../../../include/stdlib.h:329:36: error: expected declaration specifiers or '...' before 'size_t'
extern void *calloc(size_t __nele, size_t __size) __ATTR_MALLOC__;
^~~~~~
../../../../include/stdlib.h:348:35: error: expected declaration specifiers or '...' before 'size_t'
extern void *realloc(void *__ptr, size_t __size) __ATTR_MALLOC__;
^~~~~~
../../../../include/stdlib.h:350:15: error: storage class specified for parameter 'strtod'
extern double strtod(const char *__nptr, char **__endptr);
^~~~~~
../../../../include/stdlib.h:361:15: error: storage class specified for parameter 'atof'
extern double atof(const char *__nptr);
^~~~
../../../../include/stdlib.h:383:12: error: storage class specified for parameter 'rand'
extern int rand(void);
^~~~
../../../../include/stdlib.h:387:13: error: storage class specified for parameter 'srand'
extern void srand(unsigned int __seed);
^~~~~
../../../../include/stdlib.h:394:12: error: storage class specified for parameter 'rand_r'
extern int rand_r(unsigned long *__ctx);
^~~~~~
../../../../include/stdlib.h:430:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
{
^
../../../../include/stdlib.h:475:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
{
^
../../../../include/stdlib.h:518:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
{
^
../../../../include/stdlib.h:560:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
{
^
../../../../include/stdlib.h:590:13: error: storage class specified for parameter 'random'
extern long random(void);
^~~~~~
../../../../include/stdlib.h:595:13: error: storage class specified for parameter 'srandom'
extern void srandom(unsigned long __seed);
^~~~~~~
../../../../include/stdlib.h:603:13: error: storage class specified for parameter 'random_r'
extern long random_r(unsigned long *__ctx);
^~~~~~~~
../../../../include/stdlib.h:649:14: error: storage class specified for parameter 'dtostre'
extern char *dtostre(double __val, char *__s, unsigned char __prec,
^~~~~~~
../../../../include/stdlib.h:666:14: error: storage class specified for parameter 'dtostrf'
extern char *dtostrf(double __val, signed char __width,
^~~~~~~
../../../../include/stdlib.h:685:12: error: storage class specified for parameter 'atexit'
extern int atexit(void (*)(void));
^~~~~~
../../../../include/stdlib.h:686:12: error: storage class specified for parameter 'system'
extern int system (const char *);
^~~~~~
../../../../include/stdlib.h:687:14: error: storage class specified for parameter 'getenv'
extern char *getenv (const char *);
^~~~~~
In file included from ../../../../libc/misc/eewr_block_xmega.c:8:
../../../../include/assert.h:110:13: error: storage class specified for parameter '__assert'
extern void __assert(const char *__func, const char *__file,
^~~~~~~~
In file included from ../../../../include/avr/eeprom.h:50,
from ../../../../libc/misc/eewr_block_xmega.c:10:
/home/jan/programs-8/avrada/lib/gcc/avr/8.0.1/include/stddef.h:149:26: error: storage class specified for parameter 'ptrdiff_t'
typedef __PTRDIFF_TYPE__ ptrdiff_t;
^~~~~~~~~
/home/jan/programs-8/avrada/lib/gcc/avr/8.0.1/include/stddef.h:437:3: error: storage class specified for parameter 'max_align_t'
} max_align_t;
^~~~~~~~~~~
In file included from ../../../../libc/misc/eewr_block_xmega.c:10:
../../../../include/avr/eeprom.h:137:1: warning: 'pure' attribute ignored [-Wattributes]
uint8_t eeprom_read_byte (const uint8_t *__p) __ATTR_PURE__;
^~~~~~~
../../../../include/avr/eeprom.h:142:1: warning: 'pure' attribute ignored [-Wattributes]
uint16_t eeprom_read_word (const uint16_t *__p) __ATTR_PURE__;
^~~~~~~~
../../../../include/avr/eeprom.h:147:1: warning: 'pure' attribute ignored [-Wattributes]
uint32_t eeprom_read_dword (const uint32_t *__p) __ATTR_PURE__;
^~~~~~~~
../../../../include/avr/eeprom.h:152:1: warning: 'pure' attribute ignored [-Wattributes]
float eeprom_read_float (const float *__p) __ATTR_PURE__;
^~~~~
../../../../include/avr/eeprom.h:158:57: error: expected declaration specifiers or '...' before 'size_t'
void eeprom_read_block (void *__dst, const void *__src, size_t __n);
^~~~~~
../../../../include/avr/eeprom.h:185:58: error: expected declaration specifiers or '...' before 'size_t'
void eeprom_write_block (const void *__src, void *__dst, size_t __n);
^~~~~~
../../../../include/avr/eeprom.h:212:59: error: expected declaration specifiers or '...' before 'size_t'
void eeprom_update_block (const void *__src, void *__dst, size_t __n);
^~~~~~
../../../../libc/misc/eewr_block_xmega.c:55:13: error: storage class specified for parameter 'ccp_write_io'
extern void ccp_write_io (volatile uint8_t *__ioaddr, uint8_t __value);
^~~~~~~~~~~~
In file included from ../../../../libc/misc/eewr_block_xmega.c:9:
../../../../common/sectionname.h:43:33: error: expected declaration specifiers before '__attribute__'
#define ATTRIBUTE_CLIB_SECTION  __attribute__ ((section (STR(CLIB_SECTION))))
^~~~~~~~~~~~~
../../../../libc/misc/eewr_block_xmega.c:57:1: note: in expansion of macro 'ATTRIBUTE_CLIB_SECTION'
ATTRIBUTE_CLIB_SECTION
^~~~~~~~~~~~~~~~~~~~~~
../../../../common/sectionname.h:43:33: error: expected declaration specifiers before '__attribute__'
#define ATTRIBUTE_CLIB_SECTION  __attribute__ ((section (STR(CLIB_SECTION))))
^~~~~~~~~~~~~
../../../../libc/misc/eewr_block_xmega.c:93:1: note: in expansion of macro 'ATTRIBUTE_CLIB_SECTION'
ATTRIBUTE_CLIB_SECTION
^~~~~~~~~~~~~~~~~~~~~~
In file included from ../../../../include/avr/io.h:456,
from ../../../../libc/misc/eewr_block_xmega.c:4:
../../../../include/avr/iotn1614.h:5623:8: error: old-style parameter declarations in prototyped function definition
define PERIOD0  (unsigned char)~_BV(0)  /* Watchdog Timeout Period Bit 0 */
^~~~~~~
../../../../include/avr/iotn1614.h:5623:18: error: parameter name omitted
define PERIOD0  (unsigned char)~_BV(0)  /* Watchdog Timeout Period Bit 0 */
^~~~~~~~~~~~~
../../../../libc/misc/eewr_block_xmega.c:120: error: expected '{' at end of input

../../../../libc/misc/eewr_block_xmega.c:116:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
Makefile:632: recipe for target 'eewr_block_xmega.o' failed

Cheers, Jan.

avrs-admin commented 2 years ago

Balint Cristian Sat 31 Mar 2018 02:06:46 AM CEST

Jan,

avrs-admin commented 2 years ago

jan de kruyf Sat 31 Mar 2018 12:00:09 PM CEST

Cristian, That compiles fine but for some warnings.

Unfortunately I am not in a position to test the set up. I am building an Ada toolchain. I guess little of this stuff will be used, since I make Ada spec files with the MCU specifics. But if you have some piece of program and tell me howto I will gladly compile and see whether the generated code makes sense or not.

You might also want to tell me what to do about some of the warnings, then I will patch for it. This is the most annoying one:

../../../include/ctype.h:112:1: warning: ignoring attribute 'const' in declaration of a built-in function 'isgraph' because it conflicts with attribute 'pure' [-Wattributes]
extern int isgraph(int __c) __ATTR_CONST__;
^~~~~~
<built-in>: note: previous declaration here

ctype.h is full of them.

Enjoy your Easter holiday.

j.

avrs-admin commented 2 years ago

Balint Cristian Sun 01 Jul 2018 03:44:39 PM CEST

avrs-admin commented 2 years ago

Balint Cristian Tue 25 Dec 2018 08:04:19 PM CET

avrs-admin commented 2 years ago

Sven Thu 21 Feb 2019 12:57:45 PM CET

I have successfully used this patch with the ATtiny817 which works well. Are there concrete plans to get this merged?

Thanks, Sven

avrs-admin commented 2 years ago

Paul Evans Tue 12 Mar 2019 10:25:37 PM CET

I too have successfully used this patch to add support for ATtiny814 to my avr-libc. Can it be considered for mainline merging sometime please? This would help improve the uptake of these new chips.

avrs-admin commented 2 years ago

Georg-Johann Lay Mon 18 Nov 2019 09:02:11 AM CET

FYI, support for devices from the 0-series like ATmega4808 (also filed under avrxmega3) has been added to avr-gcc:

https://gcc.gnu.org/PR92545

avrs-admin commented 2 years ago

Yves Delley Wed 22 Apr 2020 02:46:03 PM CEST

I would like to use those new ATtiny devices. It would be great if those newer devices were supported, and I am willing to help with that. People here seem to have successfully used the patches here, but I seem unable to find where to apply them: Do we need just the last once (v9)? Or do we need to apply them in order? What version of libc do they apply to? Do they apply before or after bootstrap/configure/build/install? When I attempt to apply any of them to libc-2.0.0, I get lots of complaints about missing files, e.g. "devtools/generate_iosym.sh". That file doesn't exist in libc-1.8.1 either.

avrs-admin commented 2 years ago

Balint Cristian Thu 30 Apr 2020 05:03:09 PM CEST

comment #22:

I would like to use those new ATtiny devices. It would be great if those newer devices were supported, and I am willing to help with that. People here seem to have successfully used the patches here, but I seem unable to find where to apply them: Do we need just the last once (v9)? Or do we need to apply them in order? What version of libc do they apply to? Do they apply before or after bootstrap/configure/build/install? When I attempt to apply any of them to libc-2.0.0, I get lots of complaints about missing files, e.g. "devtools/generate_iosym.sh". That file doesn't exist in libc-1.8.1 either.

avrs-admin commented 2 years ago

Balint Cristian Thu 30 Apr 2020 05:08:57 PM CEST

avrs-admin commented 2 years ago

Tom Li Sun 08 Nov 2020 05:31:11 PM CET

comment #22:

When I attempt to apply any of them to libc-2.0.0, I get lots of complaints about missing files, e.g. "devtools/generate_iosym.sh". That file doesn't exist in libc-1.8.1 either.

Same problem here. It says "devtools/gen-avr-lib-tree.sh" cannot be found, even if the file is right here. After some head scratching, I realized the patch must be applied as level "-p0". Instead of "patch < avrxmega3-v10.diff", it should be "patch -p0 < avrxmega3-v10.diff". I've successfully applied the patch to SVN trunk r2551.

avrs-admin commented 2 years ago

wasti Tue 01 Dec 2020 09:06:57 AM CET

Great work all. As I am not so knowlegable@Linux, it took me a while to get that running, lots of compile problems, try and error, so I wanted to share what finally worked for me.

Other than in the manual below, I did install everything into the default path. No PREFIX, as prefixing did not work on my environment.

https://www.nongnu.org/avr-libc/user-manual/install_tools.html#install_avr_gcc

The following process did work for me.

cat /proc/version

Linux version 5.4.0-52-generic (buildd@lgw01-amd64-060) (gcc version 9.3.0 (Ubuntu 9.3.0-17ubuntu1~20.04))

sudo apt remove gcc-avr binutils-avr avr-libc

Important: close teminal and reopen to remove cached links to the binaries

set up directory

mkdir ~/libc-compile cd ~/libc-compile

#

compile and install binutils

#

wget ftp://sourceware.org/pub/binutils/snapshots/binutils-2.34.90.tar.xz tar -xf binutils-2.34.90.tar.xz cd binutils-2.34.90

mkdir obj-avr cd obj-avr ../configure --target=avr --disable-nls make sudo make install

check version

avr-ld --version

#

compile and install GCC, this takes a wile, have lunch...

#

cd ~/libc-compile

git clone -b releases/gcc-10.1.0 --single-branch git://gcc.gnu.org/git/gcc.git ./contrib/download_prerequisites

cd gcc

mkdir obj-avr cd obj-avr ../configure --target=avr --enable-languages=c,c++ --disable-nls --disable-libssp --with-dwarf2 make sudo make install

check version

avr-gcc --version

#

patch, compile and install avr-libc

# cd ~/libc-compile

svn co svn://svn.savannah.nongnu.org/avr-libc/trunk cd trunk/avr-libc/

wget -O - -q https://savannah.nongnu.org/patch/download.php?file_id=48974 >> avrxmega3-v10.diff.xz xz --decompress avrxmega3-v10.diff.xz

patch -p0 < avrxmega3-v10.diff ./bootstrap ./configure --build=./config.guess --host=avr make sudo make install

###################################

now test if it compiles

###################################

mkdir ~/libc-compile/test-program cd ~/libc-compile/test-program

echo "#define _AVRATtiny1604

include <avr/io.h>

int main(void) { while (1); }" >> main.c

avr-gcc -std=c99 -Wall -g -Os -mmcu=avrxmega3 -DF_CPU=1200000 -I.  -o main.bin main.c avr-objcopy -j .text -j .data -O ihex main.bin main.hex

avrs-admin commented 2 years ago

Balint Cristian Tue 01 Dec 2020 12:52:19 PM CET

comment #26:

Great work all. As I am not so knowlegable@Linux, it took me a while to get that running, lots of compile problems, try and error, so I wanted to share what finally worked for me.

Thank you Wasti ! One issue as you pointed out is community support. We do best what we can, each person within their own area of expertise, but proper documentation and promotion is always an issue.

Great work all. As I am not so knowlegable@Linux, it took me a while to get that running, lots of compile problems, try and error, so I wanted to share what finally worked for me.

Other than in the manual below, I did install everything into the default path. No PREFIX, as prefixing did not work on my environment.

https://www.nongnu.org/avr-libc/user-manual/install_tools.html#install_avr_gcc

The following process did work for me.

cat /proc/version

Linux version 5.4.0-52-generic (buildd@lgw01-amd64-060) (gcc version 9.3.0 (Ubuntu 9.3.0-17ubuntu1~20.04))

sudo apt remove gcc-avr binutils-avr avr-libc

Important: close teminal and reopen to remove cached links to the binaries

set up directory

mkdir ~/libc-compile cd ~/libc-compile

#

compile and install binutils

#

wget ftp://sourceware.org/pub/binutils/snapshots/binutils-2.34.90.tar.xz tar -xf binutils-2.34.90.tar.xz cd binutils-2.34.90

mkdir obj-avr cd obj-avr ../configure --target=avr --disable-nls make sudo make install

check version

avr-ld --version

#

compile and install GCC, this takes a wile, have lunch...

#

cd ~/libc-compile

git clone -b releases/gcc-10.1.0 --single-branch git://gcc.gnu.org/git/gcc.git ./contrib/download_prerequisites

cd gcc

mkdir obj-avr cd obj-avr ../configure --target=avr --enable-languages=c,c++ --disable-nls --disable-libssp --with-dwarf2 make sudo make install

check version

avr-gcc --version

#

patch, compile and install avr-libc

# cd ~/libc-compile

svn co svn://svn.savannah.nongnu.org/avr-libc/trunk cd trunk/avr-libc/

wget -O - -q https://savannah.nongnu.org/patch/download.php?file_id=48974 >> avrxmega3-v10.diff.xz xz --decompress avrxmega3-v10.diff.xz

patch -p0 < avrxmega3-v10.diff ./bootstrap ./configure --build=./config.guess --host=avr make sudo make install

###################################

now test if it compiles

###################################

mkdir ~/libc-compile/test-program cd ~/libc-compile/test-program

echo "#define _AVRATtiny1604

include <avr/io.h>

int main(void) {          while (1); }" >> main.c

avr-gcc -std=c99 -Wall -g -Os -mmcu=avrxmega3 -DF_CPU=1200000 -I.  -o main.bin main.c avr-objcopy -j .text -j .data -O ihex main.bin main.hex

comment #26:

Great work all. As I am not so knowlegable@Linux, it took me a while to get that running, lots of compile problems, try and error, so I wanted to share what finally worked for me.

Other than in the manual below, I did install everything into the default path. No PREFIX, as prefixing did not work on my environment.

https://www.nongnu.org/avr-libc/user-manual/install_tools.html#install_avr_gcc

The following process did work for me.

cat /proc/version

Linux version 5.4.0-52-generic (buildd@lgw01-amd64-060) (gcc version 9.3.0 (Ubuntu 9.3.0-17ubuntu1~20.04))

sudo apt remove gcc-avr binutils-avr avr-libc

Important: close teminal and reopen to remove cached links to the binaries

set up directory

mkdir ~/libc-compile cd ~/libc-compile

#

compile and install binutils

#

wget ftp://sourceware.org/pub/binutils/snapshots/binutils-2.34.90.tar.xz tar -xf binutils-2.34.90.tar.xz cd binutils-2.34.90

mkdir obj-avr cd obj-avr ../configure --target=avr --disable-nls make sudo make install

check version

avr-ld --version

#

compile and install GCC, this takes a wile, have lunch...

#

cd ~/libc-compile

git clone -b releases/gcc-10.1.0 --single-branch git://gcc.gnu.org/git/gcc.git ./contrib/download_prerequisites

cd gcc

mkdir obj-avr cd obj-avr ../configure --target=avr --enable-languages=c,c++ --disable-nls --disable-libssp --with-dwarf2 make sudo make install

check version

avr-gcc --version

#

patch, compile and install avr-libc

# cd ~/libc-compile

svn co svn://svn.savannah.nongnu.org/avr-libc/trunk cd trunk/avr-libc/

wget -O - -q https://savannah.nongnu.org/patch/download.php?file_id=48974 >> avrxmega3-v10.diff.xz xz --decompress avrxmega3-v10.diff.xz

patch -p0 < avrxmega3-v10.diff ./bootstrap ./configure --build=./config.guess --host=avr make sudo make install

###################################

now test if it compiles

###################################

mkdir ~/libc-compile/test-program cd ~/libc-compile/test-program

echo "#define _AVRATtiny1604

include <avr/io.h>

int main(void) {          while (1); }" >> main.c

avr-gcc -std=c99 -Wall -g -Os -mmcu=avrxmega3 -DF_CPU=1200000 -I.  -o main.bin main.c avr-objcopy -j .text -j .data -O ihex main.bin main.hex

avrs-admin commented 2 years ago

Joel Holdsworth Mon 15 Nov 2021 06:42:31 PM CET

Can we have this patch integrated and released? I have used it for a complex project on the ATtiny416, and have found no issues.

avrs-admin commented 2 years ago

Georg-Johann Lay Mon 15 Nov 2021 07:43:14 PM CET

This patch is best integrated after the changes from

https://savannah.nongnu.org/bugs/?49567

and

https://savannah.nongnu.org/bugs/?57071

which will greatly reduce the number of conflicts.

avrs-admin commented 2 years ago

Joel Holdsworth Mon 15 Nov 2021 07:55:42 PM CET

What would it take to get all these changes merged?

avrs-admin commented 2 years ago

Joel Holdsworth Tue 16 Nov 2021 02:09:08 PM CET

Is it possible to cut the Gordian knot? This patch applies cleanly and works perfectly - as far as I can tell from my testing. I see no reason why it's necessary for it to be tangled up with these other long-standing issues. I would imagine this patch could be applied, and a release made in a couple of hours work.

avrs-admin commented 2 years ago

Balint Cristian Tue 16 Nov 2021 02:39:48 PM CET

Updated avrxmega3-v11.diff.xz with latest AVR8X devices. Rebased on latest .ATDF (AVR8X only entries): Atmel.ATtiny_DFP.1.10.348.atpack Atmel.ATmega_DFP.1.7.374.atpack Header generator error fixed for DWORD types (size=4). Add FUSELOCK_DEFAULT values (as per newer original .h) New devices: attiny424, attiny426, attiny427, attiny824, attiny826, attiny827, attiny1624, attiny1626, attiny1627, attiny3224, attiny3226, attiny3227.

Tested it against SVN master.

Let me know about any help needed to merge this.

Thank you, ~Cristian.

avrs-admin commented 2 years ago

Joel Holdsworth Tue 23 Nov 2021 07:58:48 PM CET

wdt.h seems to have some issues that need fixing up. The wdt_enable() and wdt_disable() macros seem are completely inapplicable to the ATtiny416.

There seem to be similar issues in sleep.h

avrs-admin commented 2 years ago

Balint Cristian Tue 23 Nov 2021 09:09:23 PM CET

Updated avrxmega3-v12.diff.xz:

Thanks, ~Cristian.