avrilmohh / pe

0 stars 0 forks source link

Name field does not allow "s/o" #4

Open avrilmohh opened 4 days ago

avrilmohh commented 4 days ago

Steps to reproduce:

  1. execute "add n/John Doe s/o Joe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney"

image.png

This will make it hard for a person with s/o in their name to add their name to NUStates

nus-pe-script commented 1 day ago

Team's Response

Thank you for reporting this issue! However, we believe that to mention a person as a "s/o," you can still write out "son of" instead of using the "/" symbol, as we are using "/" to distinguish between different parameters. Thus the functionality would still be there as you can still type out the full name. Also, our app was not meant to keep legal names of clients, so "s/o" can be omitted without causing any issues to the app, or hinderance to the user.

image.png

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: This is not severity.Low as having a restriction on not allowing special characters like "/", "@" or "-" will cause occasional inconvenience to add people with such names to the application. In fact, having such names is not rare, as many Indians have "s/o" in their name, there are some people with "@" in their names (in fact I have a friend with @ in their name). There are also alot of people with "-" in their names.

So everytime the user adds these names in the application, they will be faced with an error message, and are forced to change to "son of" or "at" or "hyphen", which is inconvenient and not intuitive. Therefore, since this is not a very rare situation and does not only cause a minor inconvenience, it is not a severity.Low. It is a flaw that causes occasional inconvenience to some users, but these users can still continue to use the product.

image.png