search

avro-kotlin / avro4k

Avro format support for Kotlin
Apache License 2.0
194 stars 37 forks source link

Fixing sealed interface unions #119

Closed thake closed 2 years ago

thake commented 2 years ago

This should remove the need to explicitly register the subclasses of sealed interfaces. This was demonstrated in PR #113.

thake commented 2 years ago

@williamboxhall can you have a look at this PR? This should fix the problem with subclasses of sealed interface serialization.

williamboxhall commented 2 years ago

@thake thanks for this! I'll take a look tomorrow morning

williamboxhall commented 2 years ago

Can we expect a release for this soon @thake ?

thake commented 2 years ago

Looks good, at least the parts I can understand! Had an open question about if we're missing a recursion but apart from that looks like it solves the problem excellently, and great to get the diamond inheritance fix as a bonus. Thanks heaps for doing this @thake !

@williamboxhall You are right, recursion handling still has some flaws. I fix it before this PR will be merged.

thake commented 2 years ago

Closed in favor of #125