search

avro-kotlin / avro4k

Avro format support for Kotlin
Apache License 2.0
188 stars 36 forks source link

feat: Set default to null when the field type is nullable (activable by the configuration) #140

Closed Chuckame closed 1 year ago

Chuckame commented 1 year ago

Quick PR that have no impact on the existing features. I hope you will release it before the work of primitives in root :pray:

thake commented 1 year ago

@Chuckame, do you want to join me in maintaining this repo?

Chuckame commented 1 year ago

@thake yes, why not!!

Chuckame commented 1 year ago

Thanks for the PR a really useful addition. It will certainly be merged before primitive types.

Good idea, did you worked on it since the last commit to your primitives in root branch?

thake commented 1 year ago

Thanks for the PR a really useful addition. It will certainly be merged before primitive types.

Good idea, did you worked on it since the last commit to your primitives in root branch?

No, not yet. If you want, you can give it a try.

Chuckame commented 1 year ago

Yes I begun something similar to Json, proto, and other native serializers. I would like to lighten the Avro class, make some extensions and make it more configurable (starting with this pr)

Chuckame commented 1 year ago

By the way, how do you want me to make releases? That way we add a CONTRIBUTING.md 😁

thake commented 1 year ago

By the way, how do you want me to make releases? That way we add a CONTRIBUTING.md grin

I've opened up an issue #143 for that. Maybe we'll have to change something on the release workflow.

thake commented 1 year ago

Yes I begun something similar to Json, proto, and other native serializers. I would like to lighten the Avro class, make some extensions and make it more configurable (starting with this pr)

That sounds really awesome :) Do you want to talk me through before? That way I can give you some input and work out a solution together. You can find my contact details on my github profile, I think we should discuss this "face to face".

Chuckame commented 1 year ago

@thake I also added a little comment on the config field inside the codebase. Ok to merge this and release it ?