search

avryhof / ambient_api

Python module for accessing the Ambient Weather API
MIT License
32 stars 18 forks source link

Updates to support integration with other projects #4

Closed tmd224 closed 6 years ago

tmd224 commented 6 years ago

-Adding support to pass in API keys via kwargs at object creation if environmental variables are not used -Added 'Invalid API Keys' response code

I plan to use this library in another open source project which requires these changes.

codecov[bot] commented 6 years ago

Codecov Report

Merging #4 into master will decrease coverage by 22.94%. The diff coverage is 90.9%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
- Coverage   83.96%   61.02%   -22.95%     
===========================================
  Files           4        4               
  Lines         131      136        +5     
===========================================
- Hits          110       83       -27     
- Misses         21       53       +32
Impacted Files Coverage Δ
ambient_api/ambientapi.py 60.86% <100%> (-20.55%) :arrow_down:
ambient_api/settings.py 85.71% <83.33%> (-14.29%) :arrow_down:
test.py 46.15% <0%> (-53.85%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac4ad87...d0f3ac2. Read the comment docs.

avryhof commented 6 years ago

No issues here. Merging.