search

avryhof / ambient_api

Python module for accessing the Ambient Weather API
MIT License
32 stars 18 forks source link

FIX: Added a sleep to the README.md demo code to avoid user confusion #9

Closed scollis closed 4 years ago

scollis commented 4 years ago

First, thanks for this code! I just got a cheap Ambient weather station and I have had a lot of fun with the data today.

The demo code in readme.md did not work for me.. it seems having the get devices followed so quick by a get data was being blocked by the API.. a simple sleep got it working.. I think the readme as it stands could confuse users so I propose adding a sleep.

codecov[bot] commented 4 years ago

Codecov Report

Merging #9 into master will decrease coverage by 21.32%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
- Coverage   82.35%   61.02%   -21.33%     
===========================================
  Files           4        4               
  Lines         136      136               
===========================================
- Hits          112       83       -29     
- Misses         24       53       +29
Impacted Files Coverage Δ
test.py 46.15% <0.00%> (-53.85%) :arrow_down:
ambient_api/ambientapi.py 60.86% <0.00%> (-20.00%) :arrow_down:
ambient_api/settings.py 85.71% <0.00%> (+14.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5df5cae...6f025ec. Read the comment docs.

avryhof commented 4 years ago

I agree. It certainly can't hurt.