search

avsa242 / p2-spin-standard-library

A curated collection of essential Spin2 objects
MIT License
3 stars 3 forks source link

Graphics drivers FTBFS when GFX_DIRECT is defined (since new common putchar() implementation) #19

Closed avsa242 closed 7 months ago

avsa242 commented 1 year ago

Since the putchar() changes in graphics.common.spin2h, any graphics driver that provides its own putchar() when GFX_DIRECT is defined won't build. It used to be a single function that was built conditionally, but is now a function pointer. Review each driver to see if it makes sense to even have its own putchar() any longer (at least some of them use whatever plot() is defined as to do the drawing, so it's not as though they're bringing their own pixel drawing code).

avsa242 commented 8 months ago

Update: some drivers fail to build for other reasons (no box(), scroll_up_fs(), and others).

avsa242 commented 7 months ago

This should be fixed now. Some drivers really didn't (and still don't) support building with GFX_DIRECT, so a preprocessor error is thrown in those cases now. For other drivers where there is a legitimate use case, the conflicting code has been resolved.