com.mdio.sme.spin2: Review for correctness and clarity

avsa242 / p2-spin-standard-library

A curated collection of essential Spin2 objects

MIT License

3 stars 3 forks source link

Closed avsa242 closed 7 months ago

avsa242 commented 7 months ago

Just noticed a few things when looking this over:

[x] some lines note an io pin is being floated, but the actual instruction used drives it high. Confirm which behavior is actually correct and make the two consistent with one another.
[x] some variable names, e.g., _period aren't quite right (really more of a half-period). Review and rename these.

avsa242 commented 7 months ago

The MDIO pin is actually being driven through the P2's built-in 1k5R pull-up, so that's why push-pull I/O is used.

avsa242 commented 7 months ago

Renamed _period to _bit_time