avsaase / walksnail-osd-tool

Cross-platform tool for rendering the flight controller OSD and SRT data from the Walksnail Avatar HD FPV system on top of the goggle or VRX recording
GNU General Public License v3.0
99 stars 11 forks source link

Added option to force 4:3 aspect ratio #49

Open vmzhivetyev opened 7 months ago

vmzhivetyev commented 7 months ago

Problem

Setup:

  1. SkyZone sky04x v2 (not PRO) with 4:3 screen
  2. Walksnail VRX
  3. Walksnail Micro V2 Cam with 4:3 sensor

Situation:

Solution

Added a new checkbox which enables rescaling the final video (after overlaying the OSD) to 4:3 aspect ratio thus effectively shrinking it horizontally. The added ffmpeg option -aspect doesn't really change final resolution rather just specify pixel aspect ratio in the mp4 container.

vmzhivetyev commented 7 months ago

It seems the linter is not happy about the code in master:

error: field `commit` is never read
Error:    --> ui\src\util.rs:235:37
    |
235 |         Release { version: Version, commit: String },
    |         -------                     ^^^^^^
    |         |
    |         field in this variant
    |
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(dead_code)]`

error: could not compile `walksnail-osd-tool` (bin "walksnail-osd-tool") due to 1 previous error
Error: The process 'C:\Users\runneradmin\.cargo\bin\cargo.exe' failed with exit code 101