search

avstack / gst-meet

Connect GStreamer pipelines to Jitsi Meet conferences
Apache License 2.0
70 stars 25 forks source link

replaced empty ns hack with the actual namespace used #3

Closed linkmauve closed 3 years ago

linkmauve commented 3 years ago

All children of a message/presence/iq are in the jabber:client namespace in a c2s stream unless xmlns is specified.

jbg commented 3 years ago

Thanks for the contribution!

The namespace change looks great.

Switching extra_muc_featues from Vec<String> to Vec<Feature> requires every lib-gst-meet API client to add an xmpp-parsers dependency. Since Feature is effectively just a wrapper of a String, I don't think it's worth it in this case — I'd prefer to handle creating the Feature inside lib-gst-meet and keep XMPP stuff encapsulated here.

linkmauve commented 3 years ago

There, changed it back to Vec<String>!